From: Ian Campbell <ian.campbell@citrix.com>
To: xen-devel@lists.xen.org
Cc: julien.grall@linaro.org, tim@xen.org,
Ian Campbell <ian.campbell@citrix.com>,
stefano.stabellini@eu.citrix.com
Subject: [PATCH RFC 06/15] xen: arm: implement arch_set_info_guest for 64-bit vcpus
Date: Mon, 7 Oct 2013 17:39:52 +0100 [thread overview]
Message-ID: <1381164001-1446-6-git-send-email-ian.campbell@citrix.com> (raw)
In-Reply-To: <1381163944.21562.129.camel@kazak.uk.xensource.com>
This all seems too easy...
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
---
xen/arch/arm/domain.c | 66 ++++++++++++++++++++++++++++++++++++++-----------
1 file changed, 52 insertions(+), 14 deletions(-)
diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
index cb0424d..907d5c0 100644
--- a/xen/arch/arm/domain.c
+++ b/xen/arch/arm/domain.c
@@ -550,7 +550,7 @@ void arch_domain_destroy(struct domain *d)
free_xenheap_page(d->shared_info);
}
-static int is_guest_psr(uint32_t psr)
+static int is_guest_pv32_psr(uint32_t psr)
{
switch (psr & PSR_MODE_MASK)
{
@@ -569,6 +569,29 @@ static int is_guest_psr(uint32_t psr)
}
}
+
+#ifdef CONFIG_ARM_64
+static int is_guest_pv64_psr(uint32_t psr)
+{
+ if ( psr & PSR_MODE_BIT )
+ return 0;
+
+ switch (psr & PSR_MODE_MASK)
+ {
+ case PSR_MODE_EL1h:
+ case PSR_MODE_EL1t:
+ case PSR_MODE_EL0t:
+ return 1;
+ case PSR_MODE_EL3h:
+ case PSR_MODE_EL3t:
+ case PSR_MODE_EL2h:
+ case PSR_MODE_EL2t:
+ default:
+ return 0;
+ }
+}
+#endif
+
/*
* Initialise VCPU state. The context can be supplied by either the
* toolstack (XEN_DOMCTL_setvcpucontext) or the guest
@@ -577,22 +600,37 @@ static int is_guest_psr(uint32_t psr)
int arch_set_info_guest(
struct vcpu *v, vcpu_guest_context_u c)
{
+ struct domain *d = v->domain;
struct vcpu_guest_context *ctxt = c.nat;
struct vcpu_guest_core_regs *regs = &c.nat->user_regs;
- if ( !is_guest_psr(regs->cpsr) )
- return -EINVAL;
-
- if ( regs->spsr_svc && !is_guest_psr(regs->spsr_svc) )
- return -EINVAL;
- if ( regs->spsr_abt && !is_guest_psr(regs->spsr_abt) )
- return -EINVAL;
- if ( regs->spsr_und && !is_guest_psr(regs->spsr_und) )
- return -EINVAL;
- if ( regs->spsr_irq && !is_guest_psr(regs->spsr_irq) )
- return -EINVAL;
- if ( regs->spsr_fiq && !is_guest_psr(regs->spsr_fiq) )
- return -EINVAL;
+
+ if ( is_pv32_domain(d) )
+ {
+ if ( !is_guest_pv32_psr(regs->cpsr) )
+ return -EINVAL;
+
+ if ( regs->spsr_svc && !is_guest_pv32_psr(regs->spsr_svc) )
+ return -EINVAL;
+ if ( regs->spsr_abt && !is_guest_pv32_psr(regs->spsr_abt) )
+ return -EINVAL;
+ if ( regs->spsr_und && !is_guest_pv32_psr(regs->spsr_und) )
+ return -EINVAL;
+ if ( regs->spsr_irq && !is_guest_pv32_psr(regs->spsr_irq) )
+ return -EINVAL;
+ if ( regs->spsr_fiq && !is_guest_pv32_psr(regs->spsr_fiq) )
+ return -EINVAL;
+ }
+#ifdef CONFIG_ARM_64
+ else
+ {
+ if ( !is_guest_pv64_psr(regs->cpsr) )
+ return -EINVAL;
+
+ if ( regs->spsr_el1 && !is_guest_pv64_psr(regs->spsr_el1) )
+ return -EINVAL;
+ }
+#endif
vcpu_regs_user_to_hyp(v, regs);
--
1.7.10.4
next prev parent reply other threads:[~2013-10-07 16:39 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-07 16:39 [PATCH RFC 00/15] xen: arm: 64-bit guest support and domU FDT autogeneration Ian Campbell
2013-10-07 16:39 ` [PATCH RFC 01/15] xen: arm: Report aarch64 capability Ian Campbell
2013-10-10 14:25 ` Julien Grall
2013-10-07 16:39 ` [PATCH RFC 02/15] xen: arm: Add comment regard arm64 zImage v0 vs v1 Ian Campbell
2013-10-10 14:26 ` Julien Grall
2013-10-07 16:39 ` [PATCH RFC 03/15] xen: arm: allocate dom0 memory separately from preparing the dtb Ian Campbell
2013-10-10 14:38 ` Julien Grall
2013-10-24 17:06 ` Ian Campbell
2013-10-07 16:39 ` [PATCH RFC 04/15] xen: arm: add enable-method to cpu nodes for arm64 guests Ian Campbell
2013-10-10 14:40 ` Julien Grall
2013-10-07 16:39 ` [PATCH RFC 05/15] xen: arm: implement XEN_DOMCTL_set_address_size Ian Campbell
2013-10-07 16:39 ` Ian Campbell [this message]
2013-10-07 16:39 ` [PATCH RFC 07/15] xenctx: fix typo in arm64 output Ian Campbell
2013-10-10 14:43 ` Julien Grall
2013-10-24 21:47 ` Ian Campbell
2013-10-07 16:39 ` [PATCH RFC 08/15] tools: check for libfdt when building for ARM Ian Campbell
2013-10-07 16:39 ` [PATCH RFC 09/15] libxc: arm: rename various bits of zimage load with 32 suffix Ian Campbell
2013-10-10 15:27 ` Julien Grall
2013-10-07 16:39 ` [PATCH RFC 10/15] libxc: allow caller to specify guest rambase rather than hardcoding Ian Campbell
2013-10-10 15:31 ` Julien Grall
2013-10-10 15:34 ` Ian Campbell
2013-10-07 16:39 ` [PATCH RFC 11/15] libxc: allow passing a device tree blob to the guest Ian Campbell
2013-10-07 16:39 ` [PATCH RFC 12/15] libxc: support for arm64 Image format Ian Campbell
2013-10-10 15:43 ` Julien Grall
2013-10-10 15:56 ` Ian Campbell
2013-10-21 9:46 ` Ian Campbell
2013-10-21 15:11 ` Julien Grall
2013-10-07 16:39 ` [PATCH RFC 13/15] libxc: arm64 vcpu initialisation Ian Campbell
2013-10-10 15:54 ` Julien Grall
2013-10-10 15:59 ` Ian Campbell
2013-10-10 16:04 ` Julien Grall
2013-10-10 16:09 ` Ian Campbell
2013-10-14 22:36 ` Julien Grall
2013-10-07 16:40 ` [PATCH RFC 14/15] libxl: build a device tree for ARM guests Ian Campbell
2013-10-14 23:11 ` Julien Grall
2013-10-15 10:00 ` Ian Campbell
2013-10-15 13:23 ` Julien Grall
2013-10-15 13:33 ` Ian Campbell
2013-10-15 13:49 ` Julien Grall
2013-10-15 13:52 ` Ian Campbell
2013-10-15 13:46 ` Julien Grall
2013-10-07 16:40 ` [PATCH RFC 15/15] libxl: remove spurious newline from LOG() message Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1381164001-1446-6-git-send-email-ian.campbell@citrix.com \
--to=ian.campbell@citrix.com \
--cc=julien.grall@linaro.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).