xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: xen-devel@lists.xen.org
Cc: Ian Campbell <ian.campbell@citrix.com>,
	Anup Patel <anup.patel@linaro.org>,
	stefano.stabellini@eu.citrix.com, julien.grall@linaro.org,
	tim@xen.org, Pranavkumar Sawargaonkar <psawargaonkar@apm.com>
Subject: [PATCH 3/6] xen: arm: map entire memory banks on arm64
Date: Thu, 10 Oct 2013 15:43:42 +0100	[thread overview]
Message-ID: <1381416225-31043-3-git-send-email-ian.campbell@citrix.com> (raw)
In-Reply-To: <1381416204.17758.36.camel@kazak.uk.xensource.com>

Currently we only map regions which are not part of boot modules. However we
subsequently free at least some of those modules to the heaps in
discard_initial_modules and if we were unluckly with sizing/location we might
end up adding unmapped pages to the heap.

The heaps on 64-bit use 1GB mappings, so in practice this is probably pretty
unlikely and I've not actually seen it.

Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
---
 xen/arch/arm/setup.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
index 49f344c..6300802 100644
--- a/xen/arch/arm/setup.c
+++ b/xen/arch/arm/setup.c
@@ -519,6 +519,8 @@ static void __init setup_mm(unsigned long dtb_paddr, size_t dtb_size)
 
         xenheap_pages += (bank_size >> PAGE_SHIFT);
 
+        setup_xenheap_mappings(bank_start>>PAGE_SHIFT, bank_size>>PAGE_SHIFT);
+
         /* XXX we assume that the ram regions are ordered */
         s = bank_start;
         while ( s < bank_end )
@@ -535,8 +537,6 @@ static void __init setup_mm(unsigned long dtb_paddr, size_t dtb_size)
             if ( e > bank_end )
                 e = bank_end;
 
-            setup_xenheap_mappings(s>>PAGE_SHIFT, (e-s)>>PAGE_SHIFT);
-
             xenheap_mfn_end = e;
 
             dt_unreserved_regions(s, e, init_boot_pages, 0);
-- 
1.7.10.4

  parent reply	other threads:[~2013-10-10 14:43 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-10 14:43 [PATCH v2 0/6] xen: arm: fixups for systems with RAM above 4GB Ian Campbell
2013-10-10 14:43 ` [PATCH 1/6] xen: correct xenheap_bits after "xen: support RAM at addresses 0 and 4096" Ian Campbell
2013-10-10 15:14   ` Keir Fraser
2013-10-10 14:43 ` [PATCH 2/6] xen: arm: Enable 40 bit addressing in VTCR for arm64 Ian Campbell
2013-10-21 15:56   ` Julien Grall
2013-10-10 14:43 ` Ian Campbell [this message]
2013-10-23 13:54   ` [PATCH 3/6] xen: arm: map entire memory banks on arm64 Julien Grall
2013-10-10 14:43 ` [PATCH 4/6] xen: arm: make sure pagetable mask macros have appropriate size Ian Campbell
2013-10-21 15:53   ` Julien Grall
2013-10-10 14:43 ` [PATCH 5/6] xen: arm: correctly round down MFN to 1GB boundary make sure pagetable mask macros as physaddr size Ian Campbell
2013-10-23 13:52   ` Julien Grall
2013-10-10 14:43 ` [PATCH 6/6] xen: arm: Ensure HCR_EL2.RW is set correctly when building dom0 Ian Campbell
2013-10-23 10:39   ` Julien Grall
2013-10-23 10:41   ` Julien Grall
2013-10-21  9:35 ` [PATCH v2 0/6] xen: arm: fixups for systems with RAM above 4GB Ian Campbell
2013-10-23 13:55   ` Julien Grall
2013-10-24 14:07     ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1381416225-31043-3-git-send-email-ian.campbell@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=anup.patel@linaro.org \
    --cc=julien.grall@linaro.org \
    --cc=psawargaonkar@apm.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).