From: Dario Faggioli <dario.faggioli@citrix.com>
To: Elena Ufimtseva <ufimtseva@gmail.com>
Cc: Ian Campbell <Ian.Campbell@citrix.com>,
Li Yechen <lccycc123@gmail.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
sw@linux.com
Subject: Re: [PATCH RFC v2 5/7] libxl/vNUMA: VM config parsing functions
Date: Thu, 10 Oct 2013 23:32:00 +0200 [thread overview]
Message-ID: <1381440720.4389.90.camel@Abyss> (raw)
In-Reply-To: <CAEr7rXjy3H7VaknRs17tUAKGNNP2oftkepHN32J3+GaEHJZOYw@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 2003 bytes --]
On gio, 2013-10-10 at 12:25 -0400, Elena Ufimtseva wrote:
> On Thu, Oct 10, 2013 at 4:38 AM, Dario Faggioli
> > Well, let's make it like this: if you provide 2 values, it acts as you
> > say above; otherwise you have to specify all of them. If you should have
> > specified 4 (or 16) values, and you specify, say, 3 (or, say, 10) all
> > the unspecified ones will have the same default value (e.g., 10). How do
> > you like this?
>
> Yes, two have both ways is better.
>
Ok, then.
> I would even add the third way - if the number of values is power of
> number of nodes,
> take them as it is and expand by rows (as it is right now).
>
Sounds fine, although, I'm not sure I'm getting 100% of what you're
saying. What do you mean with "the number of values is power of number
of nodes"? Do you mind giving an example?
> so we have distances:
>
> 1) [10, 20] - only two values => same node 10, othes - 20;
>
Yep.
> 2) did you mean, that if vnodes = 4, vdistance = [10, 10, 10]; the
> rest of it should be 10?
> Then it means all distances are the same?
>
As said on IRC, I mean that we should have a default value for the
distances, in case the user does not say anything about them.
If it says something, but not all of it, we can try doing something wise
with what he gives us (which is exactly what we're doing above if we
have only 2 values).
However, if it's not immediate to translate what he says into something
that we need, we either exit with error or use as much info as we can,
and fill the rest with a default value (and print a warning).
Personally, I'm fine with both.
> 3) if vdistance number of elements = vnodes * vnodes, take as it is.
>
Sure.
Regards,
Dario
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2013-10-10 21:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-13 8:50 [PATCH RFC v2 5/7] libxl/vNUMA: VM config parsing functions Elena Ufimtseva
2013-09-19 14:09 ` George Dunlap
2013-09-19 14:29 ` George Dunlap
2013-10-09 18:45 ` Elena Ufimtseva
2013-10-10 8:38 ` Dario Faggioli
2013-10-10 16:25 ` Elena Ufimtseva
2013-10-10 21:32 ` Dario Faggioli [this message]
2013-10-10 22:32 ` Elena Ufimtseva
2013-10-11 11:18 ` Ian Jackson
2013-10-14 13:15 ` Dario Faggioli
2013-10-14 13:26 ` Ian Jackson
2013-10-14 16:52 ` Elena Ufimtseva
2013-10-14 16:45 ` Elena Ufimtseva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1381440720.4389.90.camel@Abyss \
--to=dario.faggioli@citrix.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=lccycc123@gmail.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=sw@linux.com \
--cc=ufimtseva@gmail.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).