From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH RFC v2 5/7] libxl/vNUMA: VM config parsing functions Date: Thu, 10 Oct 2013 23:32:00 +0200 Message-ID: <1381440720.4389.90.camel@Abyss> References: <1379062224-13894-1-git-send-email-ufimtseva@gmail.com> <1381394293.4389.81.camel@Abyss> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6412848740224360699==" Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Elena Ufimtseva Cc: Ian Campbell , Li Yechen , George Dunlap , Stefano Stabellini , Ian Jackson , "xen-devel@lists.xen.org" , sw@linux.com List-Id: xen-devel@lists.xenproject.org --===============6412848740224360699== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-f7AYeBakxL0qQciR2w9d" --=-f7AYeBakxL0qQciR2w9d Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On gio, 2013-10-10 at 12:25 -0400, Elena Ufimtseva wrote: > On Thu, Oct 10, 2013 at 4:38 AM, Dario Faggioli > > Well, let's make it like this: if you provide 2 values, it acts as you > > say above; otherwise you have to specify all of them. If you should hav= e > > specified 4 (or 16) values, and you specify, say, 3 (or, say, 10) all > > the unspecified ones will have the same default value (e.g., 10). How d= o > > you like this? >=20 > Yes, two have both ways is better. >=20 Ok, then. > I would even add the third way - if the number of values is power of > number of nodes, > take them as it is and expand by rows (as it is right now). >=20 Sounds fine, although, I'm not sure I'm getting 100% of what you're saying. What do you mean with "the number of values is power of number of nodes"? Do you mind giving an example? > so we have distances: >=20 > 1) [10, 20] - only two values =3D> same node 10, othes - 20; >=20 Yep. > 2) did you mean, that if vnodes =3D 4, vdistance =3D [10, 10, 10]; the > rest of it should be 10? > Then it means all distances are the same? >=20 As said on IRC, I mean that we should have a default value for the distances, in case the user does not say anything about them. If it says something, but not all of it, we can try doing something wise with what he gives us (which is exactly what we're doing above if we have only 2 values). However, if it's not immediate to translate what he says into something that we need, we either exit with error or use as much info as we can, and fill the rest with a default value (and print a warning). Personally, I'm fine with both. > 3) if vdistance number of elements =3D vnodes * vnodes, take as it is. >=20 Sure. Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-f7AYeBakxL0qQciR2w9d Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) iEYEABECAAYFAlJXHNAACgkQk4XaBE3IOsTEHQCgpxMaSiSC+6I1IFAHShNrYzMS 4xwAn3F+ocI7V2gNCB7FltRPaXVbrS2l =Jbu7 -----END PGP SIGNATURE----- --=-f7AYeBakxL0qQciR2w9d-- --===============6412848740224360699== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============6412848740224360699==--