From: Ian Campbell <ian.campbell@citrix.com>
To: ian.jackson@eu.citrix.com
Cc: Ian Campbell <ian.campbell@citrix.com>, xen-devel@lists.xen.org
Subject: [PATCH OSSTEST 6/6] Serial/http: use mkdtemp instead of File::Temp->newdir
Date: Fri, 11 Oct 2013 16:54:23 +0100 [thread overview]
Message-ID: <1381506863-1888-6-git-send-email-ian.campbell@citrix.com> (raw)
In-Reply-To: <1381506785.24708.66.camel@kazak.uk.xensource.com>
The latter is not available in Squeeze's File::Temp.
---
Osstest/Serial/http.pm | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/Osstest/Serial/http.pm b/Osstest/Serial/http.pm
index cb36f1c..3094baa 100644
--- a/Osstest/Serial/http.pm
+++ b/Osstest/Serial/http.pm
@@ -24,7 +24,8 @@ use warnings;
use Osstest;
use Osstest::TestSupport;
-use File::Temp;
+use File::Path qw / rmtree /;
+use File::Temp qw / mkdtemp /;
use File::Copy;
BEGIN {
@@ -64,8 +65,7 @@ sub fetch_logs {
logm("serial http from $mo->{Name} fetching $mo->{Pattern} from $mo->{Server}");
- my $dir = File::Temp->newdir();
- my $tdir = $dir->dirname;
+ my $tdir = mkdtemp("osstest.log.XXXXX") or die $!;
my $lrf = "$tdir/log-retrieval.log";
@@ -93,7 +93,7 @@ sub fetch_logs {
$df =~ s,.*/,,;
if ($lfage < $started) {
next if $done{$inum};
- logm("$df modified $lfage, skipping")
+ logm("$df modified $lfage ($started), skipping")
unless $done{$inum};
$done{$inum}= 1;
next;
@@ -107,8 +107,9 @@ sub fetch_logs {
my $dh= open_unique_stashfile(\$df);
File::Copy::copy($logfile, $dh);
}
- return;
+ rmtree($tdir);
+ return;
}
1;
--
1.7.10.4
next prev parent reply other threads:[~2013-10-11 15:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-11 15:53 [PATCH OSSTEST 0/6] Support for serial logs from marilith boxes Ian Campbell
2013-10-11 15:54 ` [PATCH OSSTEST 1/6] Standalone: Collect logs modified in the last hour Ian Campbell
2013-10-11 15:54 ` [PATCH OSSTEST 2/6] TestSupport: allow multiple host serial methods Ian Campbell
2013-10-11 15:54 ` [PATCH OSSTEST 3/6] Serial: Refactor debug key sending into separate request_debug function Ian Campbell
2013-10-11 15:54 ` [PATCH OSSTEST 4/6] Serial: collect serial logs from an http server Ian Campbell
2013-10-11 15:54 ` [PATCH OSSTEST 5/6] Serial: new module to send debug keys via xenuse Ian Campbell
2013-10-11 15:54 ` Ian Campbell [this message]
2013-10-11 17:22 ` [PATCH OSSTEST 0/6] Support for serial logs from marilith boxes Ian Jackson
2013-10-13 9:19 ` Ian Campbell
2013-10-13 9:51 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1381506863-1888-6-git-send-email-ian.campbell@citrix.com \
--to=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).