From: Ian Campbell <ian.campbell@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Stefano Stabellini <stefano.stabellini@citrix.com>,
Tim Deegan <tim@xen.org>, Keir Fraser <keir@xen.org>,
Jan Beulich <JBeulich@suse.com>,
Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH 3/3] common/spinlock: Ensure the flags parameter is wide enough
Date: Mon, 21 Oct 2013 16:15:07 +0100 [thread overview]
Message-ID: <1382368507.1657.27.camel@hastur.hellion.org.uk> (raw)
In-Reply-To: <1382362893-12603-4-git-send-email-andrew.cooper3@citrix.com>
On Mon, 2013-10-21 at 14:41 +0100, Andrew Cooper wrote:
> The previous patch in the series fixes the compilation issues I found as a
> result of this patch, but I have not tested on arm. I therefore request an
> explicit ack from an arm maintainer before this is committed.
I build tested just this patch on current staging and it failed, because
I hadn't spotted that the previous patch was generic and not x86
specific.
With patch 2/3 added both arm32 and arm64 hypervisors build for me, so:
Acked-by: Ian Campbell <ian.campbell@citrix.com>
BTW cross-compiling the hypervisor is more or less trivial, compilers
can be found at
https://launchpad.net/linaro-toolchain-binaries/+download and the runes
are:
make dist-xen XEN_TARGET_ARCH=arm32 CROSS_COMPILER=arm-linux-gnueabihf-
make dist-xen XEN_TARGET_ARCH=arm64 CROSS_COMPILER=aarch64-linux-gnu-
Ian.
next prev parent reply other threads:[~2013-10-21 15:15 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-21 13:41 [PATCH 0/3] irqsave/restore improvements Andrew Cooper
2013-10-21 13:41 ` [PATCH 1/3] x86/irq: local_irq_restore() should not blindly popf Andrew Cooper
2013-10-21 13:58 ` David Vrabel
2013-10-21 14:09 ` Keir Fraser
2013-10-21 14:32 ` Jan Beulich
2013-10-21 15:24 ` Jan Beulich
2013-10-21 14:42 ` Jan Beulich
2013-10-21 16:33 ` [Patch 1/3 v2] " Andrew Cooper
2013-10-21 18:18 ` Keir Fraser
2013-10-21 18:30 ` Andrew Cooper
2013-10-21 18:37 ` Keir Fraser
2013-10-22 8:35 ` Jan Beulich
2013-10-22 8:56 ` Andrew Cooper
2013-10-22 9:28 ` Jan Beulich
2013-10-22 10:14 ` [PATCH 1/3 v3] " Andrew Cooper
2013-10-22 13:27 ` Keir Fraser
2013-10-29 14:53 ` [Patch 1/3 v2] " Jan Beulich
2013-10-21 13:41 ` [PATCH 2/3] xen: Widen flags parameter for spinlock_irqsave() and friends Andrew Cooper
2013-10-21 13:41 ` [PATCH 3/3] common/spinlock: Ensure the flags parameter is wide enough Andrew Cooper
2013-10-21 15:15 ` Ian Campbell [this message]
2013-10-21 14:08 ` [PATCH 0/3] irqsave/restore improvements Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1382368507.1657.27.camel@hastur.hellion.org.uk \
--to=ian.campbell@citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=keir@xen.org \
--cc=stefano.stabellini@citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).