From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH 3/3] common/spinlock: Ensure the flags parameter is wide enough Date: Mon, 21 Oct 2013 16:15:07 +0100 Message-ID: <1382368507.1657.27.camel@hastur.hellion.org.uk> References: <1382362893-12603-1-git-send-email-andrew.cooper3@citrix.com> <1382362893-12603-4-git-send-email-andrew.cooper3@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1382362893-12603-4-git-send-email-andrew.cooper3@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Andrew Cooper Cc: Stefano Stabellini , Tim Deegan , Keir Fraser , Jan Beulich , Xen-devel List-Id: xen-devel@lists.xenproject.org On Mon, 2013-10-21 at 14:41 +0100, Andrew Cooper wrote: > The previous patch in the series fixes the compilation issues I found as a > result of this patch, but I have not tested on arm. I therefore request an > explicit ack from an arm maintainer before this is committed. I build tested just this patch on current staging and it failed, because I hadn't spotted that the previous patch was generic and not x86 specific. With patch 2/3 added both arm32 and arm64 hypervisors build for me, so: Acked-by: Ian Campbell BTW cross-compiling the hypervisor is more or less trivial, compilers can be found at https://launchpad.net/linaro-toolchain-binaries/+download and the runes are: make dist-xen XEN_TARGET_ARCH=arm32 CROSS_COMPILER=arm-linux-gnueabihf- make dist-xen XEN_TARGET_ARCH=arm64 CROSS_COMPILER=aarch64-linux-gnu- Ian.