From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: [PATCH] libxenstore: Use PTHREAD_STACK_MIN Date: Fri, 25 Oct 2013 08:47:35 +0100 Message-ID: <1382687255-1524-1-git-send-email-ijc@hellion.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xen.org Cc: ian.jackson@eu.citrix.com, julien.grall@linaro.org, tim@xen.org, Ian Campbell , stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org From: Ian Campbell The existing value of 16K is smaller than the arm64 minimum stack size, which is 128K. PTHREAD_STACK_MIN appears to be standard http://pubs.opengroup.org/onlinepubs/009695399/functions/pthread_attr_setstacksize.html Consindered setting a lower bound but the stack requirements of the watcher thread are pretty minimal (tens of bytes from the looks of it) and unlikely to blow PTHREAD_STACK_MIN on any useful platform. Signed-off-by: Ian Campbell Cc: ian.jackson@eu.citrix.com --- tools/xenstore/xs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/xenstore/xs.c b/tools/xenstore/xs.c index b1e6820..261b841 100644 --- a/tools/xenstore/xs.c +++ b/tools/xenstore/xs.c @@ -723,7 +723,7 @@ bool xs_watch(struct xs_handle *h, const char *path, const char *token) struct iovec iov[2]; #ifdef USE_PTHREAD -#define READ_THREAD_STACKSIZE (16 * 1024) +#define READ_THREAD_STACKSIZE PTHREAD_STACK_MIN /* We dynamically create a reader thread on demand. */ mutex_lock(&h->request_mutex); -- 1.8.4.rc3