xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] xen/arm: Add EARLY_PRINT support for Broadcom brcm platform.
@ 2013-10-29  1:50 Jon Fraser
  2013-10-31 15:07 ` Ian Campbell
  0 siblings, 1 reply; 4+ messages in thread
From: Jon Fraser @ 2013-10-29  1:50 UTC (permalink / raw)
  To: xen-devel; +Cc: julien.grall, Jon Fraser, stefano.stabellini

Enable early print support for the Broadcom A15 platform, brcm.

Signed-off-by: Jon Fraser <jfraser@broadcom.com>
---
 xen/arch/arm/Rules.mk | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/xen/arch/arm/Rules.mk b/xen/arch/arm/Rules.mk
index bd79b26..c27c2eb 100644
--- a/xen/arch/arm/Rules.mk
+++ b/xen/arch/arm/Rules.mk
@@ -77,6 +77,11 @@ EARLY_PRINTK_INC := 8250
 EARLY_UART_BASE_ADDRESS := 0x01c28000
 EARLY_UART_REG_SHIFT := 2
 endif
+ifeq ($(CONFIG_EARLY_PRINTK), brcm)
+EARLY_PRINTK_INC := 8250
+EARLY_UART_BASE_ADDRESS := 0xF0406B00
+EARLY_UART_REG_SHIFT := 2
+endif
 
 ifneq ($(EARLY_PRINTK_INC),)
 EARLY_PRINTK := y
-- 
1.7.11.3

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] xen/arm: Add EARLY_PRINT support for Broadcom brcm platform.
  2013-10-29  1:50 [PATCH] xen/arm: Add EARLY_PRINT support for Broadcom brcm platform Jon Fraser
@ 2013-10-31 15:07 ` Ian Campbell
  2013-10-31 19:39   ` Jon Fraser
  0 siblings, 1 reply; 4+ messages in thread
From: Ian Campbell @ 2013-10-31 15:07 UTC (permalink / raw)
  To: Jon Fraser; +Cc: julien.grall, stefano.stabellini, xen-devel

On Mon, 2013-10-28 at 21:50 -0400, Jon Fraser wrote:
> Enable early print support for the Broadcom A15 platform, brcm.
> 
> Signed-off-by: Jon Fraser <jfraser@broadcom.com>

Acked-by: Ian Campbell <ian.campbell@citrix.com>

I suppose this relies on your other patch to handle UARTs which are
offset into the page to be functional but it is harmless (at least to !
brcm) platforms until then?

> ---
>  xen/arch/arm/Rules.mk | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/xen/arch/arm/Rules.mk b/xen/arch/arm/Rules.mk
> index bd79b26..c27c2eb 100644
> --- a/xen/arch/arm/Rules.mk
> +++ b/xen/arch/arm/Rules.mk
> @@ -77,6 +77,11 @@ EARLY_PRINTK_INC := 8250
>  EARLY_UART_BASE_ADDRESS := 0x01c28000
>  EARLY_UART_REG_SHIFT := 2
>  endif
> +ifeq ($(CONFIG_EARLY_PRINTK), brcm)
> +EARLY_PRINTK_INC := 8250
> +EARLY_UART_BASE_ADDRESS := 0xF0406B00
> +EARLY_UART_REG_SHIFT := 2
> +endif
>  
>  ifneq ($(EARLY_PRINTK_INC),)
>  EARLY_PRINTK := y

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] xen/arm: Add EARLY_PRINT support for Broadcom brcm platform.
  2013-10-31 15:07 ` Ian Campbell
@ 2013-10-31 19:39   ` Jon Fraser
  2013-11-01 13:25     ` Ian Campbell
  0 siblings, 1 reply; 4+ messages in thread
From: Jon Fraser @ 2013-10-31 19:39 UTC (permalink / raw)
  To: Ian Campbell; +Cc: stefano.stabellini, jfraser, julien.grall, xen-devel

Yes, it's harmless to the other platforms.  Verified with test builds.

Jon

On Thu, 2013-10-31 at 15:07 +0000, Ian Campbell wrote:
> On Mon, 2013-10-28 at 21:50 -0400, Jon Fraser wrote:
> > Enable early print support for the Broadcom A15 platform, brcm.
> > 
> > Signed-off-by: Jon Fraser <jfraser@broadcom.com>
> 
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
> 
> I suppose this relies on your other patch to handle UARTs which are
> offset into the page to be functional but it is harmless (at least to !
> brcm) platforms until then?
> 
> > ---
> >  xen/arch/arm/Rules.mk | 5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/xen/arch/arm/Rules.mk b/xen/arch/arm/Rules.mk
> > index bd79b26..c27c2eb 100644
> > --- a/xen/arch/arm/Rules.mk
> > +++ b/xen/arch/arm/Rules.mk
> > @@ -77,6 +77,11 @@ EARLY_PRINTK_INC := 8250
> >  EARLY_UART_BASE_ADDRESS := 0x01c28000
> >  EARLY_UART_REG_SHIFT := 2
> >  endif
> > +ifeq ($(CONFIG_EARLY_PRINTK), brcm)
> > +EARLY_PRINTK_INC := 8250
> > +EARLY_UART_BASE_ADDRESS := 0xF0406B00
> > +EARLY_UART_REG_SHIFT := 2
> > +endif
> >  
> >  ifneq ($(EARLY_PRINTK_INC),)
> >  EARLY_PRINTK := y
> 
> 
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] xen/arm: Add EARLY_PRINT support for Broadcom brcm platform.
  2013-10-31 19:39   ` Jon Fraser
@ 2013-11-01 13:25     ` Ian Campbell
  0 siblings, 0 replies; 4+ messages in thread
From: Ian Campbell @ 2013-11-01 13:25 UTC (permalink / raw)
  To: jfraser; +Cc: julien.grall, stefano.stabellini, xen-devel

On Thu, 2013-10-31 at 15:39 -0400, Jon Fraser wrote:
> Yes, it's harmless to the other platforms.  Verified with test builds.

Applied, thanks.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2013-11-01 13:25 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-29  1:50 [PATCH] xen/arm: Add EARLY_PRINT support for Broadcom brcm platform Jon Fraser
2013-10-31 15:07 ` Ian Campbell
2013-10-31 19:39   ` Jon Fraser
2013-11-01 13:25     ` Ian Campbell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).