From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Daley Subject: [PATCH 29/29] xentrace: undeadify invalid option argument handling Date: Wed, 30 Oct 2013 20:52:05 +1300 Message-ID: <1383119525-26033-30-git-send-email-mattjd@gmail.com> References: <1383119525-26033-1-git-send-email-mattjd@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1383119525-26033-1-git-send-email-mattjd@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xen.org Cc: George Dunlap , Matthew Daley , Ian Jackson , Ian Campbell , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org Apparently it's always been like this. Coverity-ID: 1056153 Signed-off-by: Matthew Daley --- tools/xentrace/xentrace.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/xentrace/xentrace.c b/tools/xentrace/xentrace.c index 504763d..8a38e32 100644 --- a/tools/xentrace/xentrace.c +++ b/tools/xentrace/xentrace.c @@ -858,10 +858,11 @@ long sargtol(const char *restrict arg, int base) return val; + invalid: - return 0; fprintf(stderr, "Invalid option argument: %s\n\n", arg); usage(); + return 0; /* not actually reached */ } /* convert the argument string pointed to by arg to a long int representation */ -- 1.7.10.4