From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Daley Subject: [PATCH 05/29] libxc: tidy up loop construct in write_compressed Date: Wed, 30 Oct 2013 20:51:41 +1300 Message-ID: <1383119525-26033-6-git-send-email-mattjd@gmail.com> References: <1383119525-26033-1-git-send-email-mattjd@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1383119525-26033-1-git-send-email-mattjd@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xen.org Cc: Matthew Daley , Ian Jackson , Ian Campbell , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org ...otherwise the return 0 at the bottom is dead code. Coverity-ID: 1055189 Signed-off-by: Matthew Daley --- tools/libxc/xc_domain_save.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/libxc/xc_domain_save.c b/tools/libxc/xc_domain_save.c index fbc15e9..9f104a4 100644 --- a/tools/libxc/xc_domain_save.c +++ b/tools/libxc/xc_domain_save.c @@ -233,7 +233,7 @@ static int write_compressed(xc_interface *xch, comp_ctx *compress_ctx, int marker = XC_SAVE_ID_COMPRESSED_DATA; unsigned long compbuf_len = 0; - do + for(;;) { /* check for available space (atleast 8k) */ if ((ob->pos + header + XC_PAGE_SIZE * 2) > ob->size) @@ -250,7 +250,7 @@ static int write_compressed(xc_interface *xch, comp_ctx *compress_ctx, ob->size - ob->pos - header, &compbuf_len); if (!rc) - return 0; + break; if (outbuf_hardwrite(xch, ob, fd, &marker, sizeof(marker)) < 0) { @@ -270,7 +270,7 @@ static int write_compressed(xc_interface *xch, comp_ctx *compress_ctx, ERROR("Error when writing compressed chunk"); return -1; } - } while (rc != 0); + } return 0; } -- 1.7.10.4