xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Ian Campbell <Ian.Campbell@citrix.com>
To: Jon Fraser <jfraser@broadcom.com>
Cc: julien.grall@linaro.org, stefano.stabellini@eu.citrix.com,
	xen-devel@lists.xen.org
Subject: Re: [PATCH] xen/arm: Add EARLY_PRINT support for Broadcom brcm platform.
Date: Thu, 31 Oct 2013 15:07:26 +0000	[thread overview]
Message-ID: <1383232046.25018.101.camel@dagon.hellion.org.uk> (raw)
In-Reply-To: <1383011431-29539-1-git-send-email-jfraser@broadcom.com>

On Mon, 2013-10-28 at 21:50 -0400, Jon Fraser wrote:
> Enable early print support for the Broadcom A15 platform, brcm.
> 
> Signed-off-by: Jon Fraser <jfraser@broadcom.com>

Acked-by: Ian Campbell <ian.campbell@citrix.com>

I suppose this relies on your other patch to handle UARTs which are
offset into the page to be functional but it is harmless (at least to !
brcm) platforms until then?

> ---
>  xen/arch/arm/Rules.mk | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/xen/arch/arm/Rules.mk b/xen/arch/arm/Rules.mk
> index bd79b26..c27c2eb 100644
> --- a/xen/arch/arm/Rules.mk
> +++ b/xen/arch/arm/Rules.mk
> @@ -77,6 +77,11 @@ EARLY_PRINTK_INC := 8250
>  EARLY_UART_BASE_ADDRESS := 0x01c28000
>  EARLY_UART_REG_SHIFT := 2
>  endif
> +ifeq ($(CONFIG_EARLY_PRINTK), brcm)
> +EARLY_PRINTK_INC := 8250
> +EARLY_UART_BASE_ADDRESS := 0xF0406B00
> +EARLY_UART_REG_SHIFT := 2
> +endif
>  
>  ifneq ($(EARLY_PRINTK_INC),)
>  EARLY_PRINTK := y

  reply	other threads:[~2013-10-31 15:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-29  1:50 [PATCH] xen/arm: Add EARLY_PRINT support for Broadcom brcm platform Jon Fraser
2013-10-31 15:07 ` Ian Campbell [this message]
2013-10-31 19:39   ` Jon Fraser
2013-11-01 13:25     ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1383232046.25018.101.camel@dagon.hellion.org.uk \
    --to=ian.campbell@citrix.com \
    --cc=jfraser@broadcom.com \
    --cc=julien.grall@linaro.org \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).