Re: netback BUG_ON when using copy_skb=1

[Ian Campbell <Ian.Campbell@citrix.com>]

On Mon, 2013-10-28 at 11:43 +0000, Wei Liu wrote:
> On Sat, Oct 26, 2013 at 04:32:08PM +0800, jerry wrote:
> [...]
> > 
> >    The patch is as follows:
> > --- drivers/xen/netback/xenbus.c.old    2013-10-26 16:23:07.000000000 +0800
> > +++ drivers/xen/netback/xenbus.c        2013-10-26 16:23:31.000000000 +0800
> > @@ -156,9 +156,6 @@
> >         if (err)
> >                 goto fail;
> > 
> > -       /* This kicks hotplug scripts, so do it immediately. */
> > -       backend_create_netif(be);
> > -
> >         return 0;
> > 
> >  abort_transaction:
> > 
> >    Do you have some ideas?
> > 
> 
> My gut feeling is that this sort of change is regression-prone but we
> have to live with that.
> 

This thread/fix doesn't apply to upstream netback, which doesn't have
copy_skb mode, right?

> In any case, does upstream changeset ea732dff5c (xen-netback: Handle
> backend state transitions in a more robust way) useful to you?
> 
> 
> Wei.
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel