From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: netback BUG_ON when using copy_skb=1
Date: Thu, 31 Oct 2013 15:17:11 +0000
Message-ID: <1383232631.25018.107.camel@dagon.hellion.org.uk>
References: <525E125B.80100@huawei.com>
	<525E903602000078000FB6DF@nat28.tlf.novell.com>
	<526B7E08.8050608@huawei.com>
	<20131028114329.GC23262@zion.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <Ian.Campbell@citrix.com>) id 1Vbtzo-0006xk-6g
	for xen-devel@lists.xenproject.org; Thu, 31 Oct 2013 15:17:16 +0000
In-Reply-To: <20131028114329.GC23262@zion.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: "qianhuibin@huawei.com" <qianhuibin@huawei.com>, jerry <jerry.lilijun@huawei.com>, liuyongan@huawei.com, wangfuhai@huawei.com, Jan Beulich <JBeulich@suse.com>, qinchuanyu@huawei.com, xen-devel <xen-devel@lists.xenproject.org>
List-Id: xen-devel@lists.xenproject.org

On Mon, 2013-10-28 at 11:43 +0000, Wei Liu wrote:
> On Sat, Oct 26, 2013 at 04:32:08PM +0800, jerry wrote:
> [...]
> > 
> >    The patch is as follows:
> > --- drivers/xen/netback/xenbus.c.old    2013-10-26 16:23:07.000000000 +0800
> > +++ drivers/xen/netback/xenbus.c        2013-10-26 16:23:31.000000000 +0800
> > @@ -156,9 +156,6 @@
> >         if (err)
> >                 goto fail;
> > 
> > -       /* This kicks hotplug scripts, so do it immediately. */
> > -       backend_create_netif(be);
> > -
> >         return 0;
> > 
> >  abort_transaction:
> > 
> >    Do you have some ideas?
> > 
> 
> My gut feeling is that this sort of change is regression-prone but we
> have to live with that.
> 

This thread/fix doesn't apply to upstream netback, which doesn't have
copy_skb mode, right?

> In any case, does upstream changeset ea732dff5c (xen-netback: Handle
> backend state transitions in a more robust way) useful to you?
> 
> 
> Wei.
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel