From: Ian Campbell <Ian.Campbell@citrix.com>
To: Julien Grall <julien.grall@linaro.org>
Cc: Jon Fraser <jfraser@broadcom.com>, Tim Deegan <tim@xen.org>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH] xen/arm: UART addresses are not always aligned to a page.
Date: Thu, 31 Oct 2013 16:15:39 +0000 [thread overview]
Message-ID: <1383236139.25018.126.camel@dagon.hellion.org.uk> (raw)
In-Reply-To: <CAPnVf8zh13Tb844rpxPK1bjRk741c9oz8VrXOZfMaQgEs6EVkA@mail.gmail.com>
On Wed, 2013-10-30 at 11:57 -0700, Julien Grall wrote:
> On 28 October 2013 18:28, Jon Fraser <jfraser@broadcom.com> wrote:
> > /* Map the DTB in the boot misc slot */
> > diff --git a/xen/include/asm-arm/asm_defns.h b/xen/include/asm-arm/asm_defns.h
> > index 36e72ff..5bcaa44 100644
> > --- a/xen/include/asm-arm/asm_defns.h
> > +++ b/xen/include/asm-arm/asm_defns.h
> > @@ -7,6 +7,9 @@
> > #endif
> > #include <asm/processor.h>
> >
> > +/* Offset in page of UART base address */
> > +#define UART_OFFSET (EARLY_UART_BASE_ADDRESS & ~PAGE_MASK)
> > +
>
> Actually I would move this define in asm/early-printk.h. It's the best place.
> Can you also rename the name to EARLY_UART_OFFSET?
>
> In order to avoid numerous FIXMAP(CONSOLE) + UART_OFFSET, is it
> possible to create a define EARLY_UART_VIRTUAL_ADDRESS and use it
> everywhere?
I agree with all 3 suggestions here.
Ian.
prev parent reply other threads:[~2013-10-31 16:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-24 18:35 [PATCH] xen/arm: UART addresses are not always aligned to a page Jon Fraser
2013-10-25 11:28 ` Julien Grall
2013-10-25 22:43 ` Jon Fraser
2013-10-29 1:28 ` Jon Fraser
2013-10-30 18:57 ` Julien Grall
2013-10-31 16:15 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1383236139.25018.126.camel@dagon.hellion.org.uk \
--to=ian.campbell@citrix.com \
--cc=jfraser@broadcom.com \
--cc=julien.grall@linaro.org \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).