From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Daley Subject: [PATCH v2] libxl: check for xc_domain_shutdown failure in libxl__domain_suspend_common_callback Date: Fri, 1 Nov 2013 13:30:44 +1300 Message-ID: <1383265844-10862-1-git-send-email-mattjd@gmail.com> References: <1383255367.5436.148.camel@dagon.hellion.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1383255367.5436.148.camel@dagon.hellion.org.uk> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xen.org Cc: Matthew Daley , Ian Jackson , Ian Campbell , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org Coverity-ID: 1055048 Signed-off-by: Matthew Daley --- v2: Don't log ret in error case, log errno instead tools/libxl/libxl_dom.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tools/libxl/libxl_dom.c b/tools/libxl/libxl_dom.c index c164469..1812bdc 100644 --- a/tools/libxl/libxl_dom.c +++ b/tools/libxl/libxl_dom.c @@ -1041,7 +1041,11 @@ int libxl__domain_suspend_common_callback(void *user) if (dss->hvm && (!hvm_pvdrv || hvm_s_state)) { LOG(DEBUG, "Calling xc_domain_shutdown on HVM domain"); - xc_domain_shutdown(CTX->xch, domid, SHUTDOWN_suspend); + ret = xc_domain_shutdown(CTX->xch, domid, SHUTDOWN_suspend); + if (ret < 0) { + LOGE(ERROR, "xc_domain_shutdown failed"); + return 0; + } /* The guest does not (need to) respond to this sort of request. */ dss->guest_responded = 1; } else { -- 1.7.10.4