From: Nathan Studer <nate.studer@dornerworks.com>
To: xen-devel@lists.xen.org
Cc: George Dunlap <george.dunlap@eu.citrix.com>,
Juergen Gross <juergen.gross@ts.fujitsu.com>,
Keir Fraser <keir@xen.org>,
Nathan Studer <nate.studer@dornerworks.com>
Subject: [Patch] Call sched_destroy_domain before cpupool_rm_domain.
Date: Sun, 3 Nov 2013 22:03:54 -0500 [thread overview]
Message-ID: <1383534234-3933-1-git-send-email-nate.studer@dornerworks.com> (raw)
From: Nathan Studer <nate.studer@dornerworks.com>
The domain destruction code, removes a domain from its cpupool
before attempting to destroy its scheduler information. Since
the scheduler framework uses the domain's cpupool information
to decide on which scheduler ops to use, this results in the
the wrong scheduler's destroy domain function being called
when the cpupool scheduler and the initial scheduler are
different.
Correct this by destroying the domain's scheduling information
before removing it from the pool.
Signed-off-by: Nathan Studer <nate.studer@dornerworks.com>
---
xen/common/domain.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/xen/common/domain.c b/xen/common/domain.c
index 5999779..78ce968 100644
--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -727,10 +727,10 @@ static void complete_domain_destroy(struct rcu_head *head)
rangeset_domain_destroy(d);
- cpupool_rm_domain(d);
-
sched_destroy_domain(d);
+ cpupool_rm_domain(d);
+
/* Free page used by xen oprofile buffer. */
#ifdef CONFIG_XENOPROF
free_xenoprof_pages(d);
--
1.7.9.5
next reply other threads:[~2013-11-04 3:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-04 3:03 Nathan Studer [this message]
2013-11-04 6:30 ` [Patch] Call sched_destroy_domain before cpupool_rm_domain Juergen Gross
2013-11-04 9:26 ` Dario Faggioli
2013-11-04 9:58 ` Juergen Gross
2013-11-04 15:22 ` Nate Studer
2013-11-05 5:59 ` Juergen Gross
2013-11-07 7:39 ` Jan Beulich
2013-11-07 9:09 ` Juergen Gross
2013-11-07 9:37 ` Jan Beulich
2013-11-07 9:43 ` Juergen Gross
2013-11-04 9:33 ` Andrew Cooper
2013-11-05 21:09 ` Keir Fraser
2013-11-04 15:10 ` George Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1383534234-3933-1-git-send-email-nate.studer@dornerworks.com \
--to=nate.studer@dornerworks.com \
--cc=george.dunlap@eu.citrix.com \
--cc=juergen.gross@ts.fujitsu.com \
--cc=keir@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).