From: Dario Faggioli <dario.faggioli@citrix.com>
To: Juergen Gross <juergen.gross@ts.fujitsu.com>
Cc: George Dunlap <george.dunlap@eu.citrix.com>,
Keir Fraser <keir@xen.org>,
Nathan Studer <nate.studer@dornerworks.com>,
Jan Beulich <JBeulich@suse.com>,
xen-devel@lists.xen.org
Subject: Re: [Patch] Call sched_destroy_domain before cpupool_rm_domain.
Date: Mon, 4 Nov 2013 10:26:07 +0100 [thread overview]
Message-ID: <1383557167.9207.35.camel@Solace> (raw)
In-Reply-To: <52773EF2.8000308@ts.fujitsu.com>
[-- Attachment #1.1: Type: text/plain, Size: 1294 bytes --]
On lun, 2013-11-04 at 07:30 +0100, Juergen Gross wrote:
> On 04.11.2013 04:03, Nathan Studer wrote:
> > From: Nathan Studer <nate.studer@dornerworks.com>
> >
> > The domain destruction code, removes a domain from its cpupool
> > before attempting to destroy its scheduler information. Since
> > the scheduler framework uses the domain's cpupool information
> > to decide on which scheduler ops to use, this results in the
> > the wrong scheduler's destroy domain function being called
> > when the cpupool scheduler and the initial scheduler are
> > different.
> >
> > Correct this by destroying the domain's scheduling information
> > before removing it from the pool.
> >
> > Signed-off-by: Nathan Studer <nate.studer@dornerworks.com>
>
> Reviewed-by: Juergen Gross <juergen.gross@ts.fujitsu.com>
>
I think this is a candidate for backports too, isn't it?
Nathan, what was happening without this patch? Are you able to quickly
figure out what previous Xen versions suffers from the same bug?
Dario
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2013-11-04 9:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-04 3:03 [Patch] Call sched_destroy_domain before cpupool_rm_domain Nathan Studer
2013-11-04 6:30 ` Juergen Gross
2013-11-04 9:26 ` Dario Faggioli [this message]
2013-11-04 9:58 ` Juergen Gross
2013-11-04 15:22 ` Nate Studer
2013-11-05 5:59 ` Juergen Gross
2013-11-07 7:39 ` Jan Beulich
2013-11-07 9:09 ` Juergen Gross
2013-11-07 9:37 ` Jan Beulich
2013-11-07 9:43 ` Juergen Gross
2013-11-04 9:33 ` Andrew Cooper
2013-11-05 21:09 ` Keir Fraser
2013-11-04 15:10 ` George Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1383557167.9207.35.camel@Solace \
--to=dario.faggioli@citrix.com \
--cc=JBeulich@suse.com \
--cc=george.dunlap@eu.citrix.com \
--cc=juergen.gross@ts.fujitsu.com \
--cc=keir@xen.org \
--cc=nate.studer@dornerworks.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).