From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [Patch] Call sched_destroy_domain before
 cpupool_rm_domain.
Date: Mon, 4 Nov 2013 10:26:07 +0100
Message-ID: <1383557167.9207.35.camel@Solace>
References: <1383534234-3933-1-git-send-email-nate.studer@dornerworks.com>
	<52773EF2.8000308@ts.fujitsu.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8011539716958790930=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <52773EF2.8000308@ts.fujitsu.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Juergen Gross <juergen.gross@ts.fujitsu.com>
Cc: George Dunlap <george.dunlap@eu.citrix.com>, Keir Fraser <keir@xen.org>, Nathan Studer <nate.studer@dornerworks.com>, Jan Beulich <JBeulich@suse.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

--===============8011539716958790930==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-6mor4dgiRoP5YS2zCE/h"

--=-6mor4dgiRoP5YS2zCE/h
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On lun, 2013-11-04 at 07:30 +0100, Juergen Gross wrote:
> On 04.11.2013 04:03, Nathan Studer wrote:
> > From: Nathan Studer <nate.studer@dornerworks.com>
> >
> > The domain destruction code, removes a domain from its cpupool
> > before attempting to destroy its scheduler information.  Since
> > the scheduler framework uses the domain's cpupool information
> > to decide on which scheduler ops to use, this results in the
> > the wrong scheduler's destroy domain function being called
> > when the cpupool scheduler and the initial scheduler are
> > different.
> >
> > Correct this by destroying the domain's scheduling information
> > before removing it from the pool.
> >
> > Signed-off-by: Nathan Studer <nate.studer@dornerworks.com>
>=20
> Reviewed-by: Juergen Gross <juergen.gross@ts.fujitsu.com>
>=20
I think this is a candidate for backports too, isn't it?

Nathan, what was happening without this patch? Are you able to quickly
figure out what previous Xen versions suffers from the same bug?

Dario

--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


--=-6mor4dgiRoP5YS2zCE/h
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.15 (GNU/Linux)

iEYEABECAAYFAlJ3aC8ACgkQk4XaBE3IOsRG9wCfYEm+fGbCtPFoUI7uL1UoGUn4
OhoAnAyLoFw/pdw5fCvkOGw9/fVDg0WT
=AmTs
-----END PGP SIGNATURE-----

--=-6mor4dgiRoP5YS2zCE/h--


--===============8011539716958790930==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============8011539716958790930==--