From: Don Slutz <dslutz@verizon.com>
To: xen-devel@lists.xen.org, Keir Fraser <keir@xen.org>,
Matthew Daley <mattjd@gmail.com>, Jan Beulich <JBeulich@suse.com>,
Ian Campbell <Ian.Campbell@citrix.com>
Cc: Don Slutz <dslutz@verizon.com>
Subject: [PATCH v3 2/3] get_maintainer.pl: Convert to Xen tree
Date: Tue, 5 Nov 2013 09:11:50 -0500 [thread overview]
Message-ID: <1383660711-12113-3-git-send-email-dslutz@terremark.com> (raw)
In-Reply-To: <1383660711-12113-2-git-send-email-dslutz@terremark.com>
From: Don Slutz <dslutz@verizon.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
Signed-off-by: Don Slutz <dslutz@verizon.com>
---
scripts/get_maintainer.pl | 54 +++++++++++++++++++----------------------------
1 file changed, 22 insertions(+), 32 deletions(-)
diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index 5e4fb14..7465c2b 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -13,11 +13,11 @@
use strict;
my $P = $0;
-my $V = '0.26';
+my $V = '0.26-xen';
use Getopt::Long qw(:config no_auto_abbrev);
-my $lk_path = "./";
+my $xen_path = "./";
my $email = 1;
my $email_usename = 1;
my $email_maintainer = 1;
@@ -260,9 +260,9 @@ if ($email &&
die "$P: Please select at least 1 email option\n";
}
-if (!top_of_kernel_tree($lk_path)) {
+if (!top_of_tree($xen_path)) {
die "$P: The current directory does not appear to be "
- . "a linux kernel source tree.\n";
+ . "a Xen source tree.\n";
}
## Read MAINTAINERS for type/value pairs
@@ -270,7 +270,7 @@ if (!top_of_kernel_tree($lk_path)) {
my @typevalue = ();
my %keyword_hash;
-open (my $maint, '<', "${lk_path}MAINTAINERS")
+open (my $maint, '<', "${xen_path}MAINTAINERS")
or die "$P: Can't open MAINTAINERS: $!\n";
while (<$maint>) {
my $line = $_;
@@ -314,9 +314,9 @@ sub read_mailmap {
addresses => {}
};
- return if (!$email_use_mailmap || !(-f "${lk_path}.mailmap"));
+ return if (!$email_use_mailmap || !(-f "${xen_path}.mailmap"));
- open(my $mailmap_file, '<', "${lk_path}.mailmap")
+ open(my $mailmap_file, '<', "${xen_path}.mailmap")
or warn "$P: Can't open .mailmap: $!\n";
while (<$mailmap_file>) {
@@ -798,7 +798,7 @@ Notes:
--git-min-signatures, --git-max-maintainers, --git-min-percent, and
--git-blame
Use --hg-since not --git-since to control date selection
- File ".get_maintainer.conf", if it exists in the linux kernel source root
+ File ".get_maintainer.conf", if it exists in the Xen source root
directory, can change whatever get_maintainer defaults are desired.
Entries in this file can be any command line argument.
This file is prepended to any additional command line arguments.
@@ -806,28 +806,18 @@ Notes:
EOT
}
-sub top_of_kernel_tree {
- my ($lk_path) = @_;
-
- if ($lk_path ne "" && substr($lk_path,length($lk_path)-1,1) ne "/") {
- $lk_path .= "/";
- }
- if ( (-f "${lk_path}COPYING")
- && (-f "${lk_path}CREDITS")
- && (-f "${lk_path}Kbuild")
- && (-f "${lk_path}MAINTAINERS")
- && (-f "${lk_path}Makefile")
- && (-f "${lk_path}README")
- && (-d "${lk_path}Documentation")
- && (-d "${lk_path}arch")
- && (-d "${lk_path}include")
- && (-d "${lk_path}drivers")
- && (-d "${lk_path}fs")
- && (-d "${lk_path}init")
- && (-d "${lk_path}ipc")
- && (-d "${lk_path}kernel")
- && (-d "${lk_path}lib")
- && (-d "${lk_path}scripts")) {
+sub top_of_tree {
+ my ($xen_path) = @_;
+
+ if ($xen_path ne "" && substr($xen_path,length($xen_path)-1,1) ne "/") {
+ $xen_path .= "/";
+ }
+ if ( (-f "${xen_path}COPYING")
+ && (-f "${xen_path}MAINTAINERS")
+ && (-f "${xen_path}Makefile")
+ && (-d "${xen_path}docs")
+ && (-f "${xen_path}CODING_STYLE")
+ && (-d "${xen_path}xen")) {
return 1;
}
return 0;
@@ -1398,8 +1388,8 @@ sub vcs_exists {
if (!$printed_novcs) {
warn("$P: No supported VCS found. Add --nogit to options?\n");
warn("Using a git repository produces better results.\n");
- warn("Try Linus Torvalds' latest git repository using:\n");
- warn("git clone git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git\n");
+ warn("Try latest git repository using:\n");
+ warn("git clone git://xenbits.xen.org/xen.git\n");
$printed_novcs = 1;
}
return 0;
--
1.8.4
next prev parent reply other threads:[~2013-11-05 14:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-05 14:11 [PATCH v3 0/3] Add get_maintainer.pl to Xen Don Slutz
2013-11-05 14:11 ` [PATCH v3 1/3] Add linux version of get_maintainer.pl Don Slutz
2013-11-05 14:11 ` Don Slutz [this message]
2013-11-05 14:11 ` [PATCH v3 3/3] get_maintainer.pl: Adjust to review comments Don Slutz
2013-11-05 14:19 ` Ian Campbell
2013-11-05 14:43 ` Don Slutz
2013-11-05 14:50 ` Ian Campbell
2013-11-05 14:53 ` Don Slutz
2013-11-05 14:22 ` [PATCH v3 0/3] Add get_maintainer.pl to Xen Ian Campbell
2013-11-19 14:03 ` Ian Campbell
2013-11-19 15:50 ` Don Slutz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1383660711-12113-3-git-send-email-dslutz@terremark.com \
--to=dslutz@verizon.com \
--cc=Ian.Campbell@citrix.com \
--cc=JBeulich@suse.com \
--cc=keir@xen.org \
--cc=mattjd@gmail.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).