From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH RESEND 05/12] xen: numa-sched: make space for per-vcpu node-affinity Date: Wed, 6 Nov 2013 17:53:51 +0100 Message-ID: <1383756831.9207.169.camel@Solace> References: <20131105142844.30446.78671.stgit@Solace> <20131105143500.30446.9976.stgit@Solace> <5279143702000078000FFB15@nat28.tlf.novell.com> <527908B2.5090208@eu.citrix.com> <52790A93.4020903@eu.citrix.com> <1383738090.9207.113.camel@Solace> <527A5679.9000301@eu.citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1061215413264545459==" Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Ve6NY-0004bU-FB for xen-devel@lists.xenproject.org; Wed, 06 Nov 2013 16:54:52 +0000 In-Reply-To: <527A5679.9000301@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: George Dunlap Cc: Keir Fraser , Ian Campbell , Li Yechen , Andrew Cooper , Ian Jackson , Jan Beulich , xen-devel , Matt Wilson , Elena Ufimtseva List-Id: xen-devel@lists.xenproject.org --===============1061215413264545459== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-hPoS1UvzaPjDTZZnZXfN" --=-hPoS1UvzaPjDTZZnZXfN Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On mer, 2013-11-06 at 14:47 +0000, George Dunlap wrote: > On 06/11/13 11:41, Dario Faggioli wrote: > > There's of course the option of renaming XEN_DOMCTL_setvcpuaffinity to > > XEN_DOMCTL_setvcpuhardaffinity (and, while there, put some '_' in it! > > )... But is that really an option? And even if it is an option for the > > hypervisor, and perhaps, libxc, I'm quite sure it's not for libxl... Am > > I wrong? >=20 > I think vcpuaffinity is a domctl, which means it's a interface to libxc,= =20 > and thus malleable. So I *think* we could actually just add a parameter= =20 > to vcpuaffinity to say "hard" or "soft". (Correct me if I'm wrong, Jan.) >=20 Ok, that certainly make it a lot easier than I thought. I'll take it that this also holds for xc_vcpu_setaffinity(), and will add a flag there too. > Where we need to consider backwards compatibility is in the libxl=20 > interface.=20 > Sure. > I'm not sure whether the best thing to do there. I think we=20 > can't break the existing API, so we need to keep=20 > libxl_set_vcpuaffinity() available for old callers. Options include: > * Just add libxl_set_vcpuaffinity_soft(), and leave the first one as it i= s > All these three looks sensible to me. Personally, I think I'd like this first one the most. Anyway... > * Add libxl_set_vcpu_affinity_[something]() which takes a soft/hard=20 > flag, and deprecate the existing one > * Redefine libxl_set_vcpuaffinity() to include a soft/hard flag, bumping= =20 > the API version and having a work-around for old callers. >=20 > IanJ / IanC, any opinions? >=20 ... Sure, let's hear the maintainers! :-) =20 Thanks and Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-hPoS1UvzaPjDTZZnZXfN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) iEUEABECAAYFAlJ6dB8ACgkQk4XaBE3IOsQRAwCfcfh+L59NcccTttnv4JOn1sAr pKAAlinn1QEoI6Ok9Q1OVq8wuhY/O6U= =Mvjx -----END PGP SIGNATURE----- --=-hPoS1UvzaPjDTZZnZXfN-- --===============1061215413264545459== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============1061215413264545459==--