xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Matthew Daley <mattjd@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: Matthew Daley <mattjd@gmail.com>, Ian Campbell <ian.campbell@citrix.com>
Subject: [PATCH] xen/arm: correct duplicate MPIDR check to actually skip the node
Date: Fri,  8 Nov 2013 13:32:03 +1300	[thread overview]
Message-ID: <1383870723-9579-1-git-send-email-mattjd@gmail.com> (raw)

Signed-off-by: Matthew Daley <mattjd@gmail.com>
---
I assume this was what was really intended...

 xen/arch/arm/smpboot.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/xen/arch/arm/smpboot.c b/xen/arch/arm/smpboot.c
index b836be4..6c90fa6 100644
--- a/xen/arch/arm/smpboot.c
+++ b/xen/arch/arm/smpboot.c
@@ -161,9 +161,11 @@ void __init smp_init_cpus(void)
                 printk(XENLOG_WARNING
                        "cpu node `%s`: duplicate /cpu reg properties in the DT\n",
                        dt_node_full_name(cpu));
-                continue;
+                break;
             }
         }
+        if ( j != cpuidx )
+            continue;
 
         /*
          * Build a stashed array of MPIDR values. Numbering scheme requires
-- 
1.7.10.4

             reply	other threads:[~2013-11-08  0:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-08  0:32 Matthew Daley [this message]
2013-11-11 16:10 ` [PATCH] xen/arm: correct duplicate MPIDR check to actually skip the node Ian Campbell
2013-11-11 19:54   ` Julien Grall
2013-11-19 14:53     ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1383870723-9579-1-git-send-email-mattjd@gmail.com \
    --to=mattjd@gmail.com \
    --cc=ian.campbell@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).