From: Bob Liu <lliubbo@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: Bob Liu <bob.liu@oracle.com>,
keir@xen.org, ian.campbell@citrix.com, JBeulich@suse.com
Subject: [PATCH v2 01/11] tmem: cleanup: drop COMPARE_COPY_PAGE_SSE2
Date: Fri, 8 Nov 2013 09:03:47 +0800 [thread overview]
Message-ID: <1383872637-15486-2-git-send-email-bob.liu@oracle.com> (raw)
In-Reply-To: <1383872637-15486-1-git-send-email-bob.liu@oracle.com>
COMPARE_COPY_PAGE_SSE2 never be used in other place, memcpy() is enough.
Signed-off-by: Bob Liu <bob.liu@oracle.com>
---
xen/common/tmem.c | 14 --------------
xen/common/tmem_xen.c | 35 -----------------------------------
2 files changed, 49 deletions(-)
diff --git a/xen/common/tmem.c b/xen/common/tmem.c
index a122651..215722b 100644
--- a/xen/common/tmem.c
+++ b/xen/common/tmem.c
@@ -95,14 +95,7 @@ DECL_CYC_COUNTER(non_succ_get);
DECL_CYC_COUNTER(non_succ_put);
DECL_CYC_COUNTER(flush);
DECL_CYC_COUNTER(flush_obj);
-#ifdef COMPARE_COPY_PAGE_SSE2
-EXTERN_CYC_COUNTER(pg_copy1);
-EXTERN_CYC_COUNTER(pg_copy2);
-EXTERN_CYC_COUNTER(pg_copy3);
-EXTERN_CYC_COUNTER(pg_copy4);
-#else
EXTERN_CYC_COUNTER(pg_copy);
-#endif
DECL_CYC_COUNTER(compress);
DECL_CYC_COUNTER(decompress);
@@ -2172,14 +2165,7 @@ static int tmemc_list_global_perf(tmem_cli_va_param_t buf, int off,
n += SCNPRINTF_CYC_COUNTER(info+n,BSIZE-n,non_succ_put,"p");
n += SCNPRINTF_CYC_COUNTER(info+n,BSIZE-n,flush,"F");
n += SCNPRINTF_CYC_COUNTER(info+n,BSIZE-n,flush_obj,"O");
-#ifdef COMPARE_COPY_PAGE_SSE2
- n += SCNPRINTF_CYC_COUNTER(info+n,BSIZE-n,pg_copy1,"1");
- n += SCNPRINTF_CYC_COUNTER(info+n,BSIZE-n,pg_copy2,"2");
- n += SCNPRINTF_CYC_COUNTER(info+n,BSIZE-n,pg_copy3,"3");
- n += SCNPRINTF_CYC_COUNTER(info+n,BSIZE-n,pg_copy4,"4");
-#else
n += SCNPRINTF_CYC_COUNTER(info+n,BSIZE-n,pg_copy,"C");
-#endif
n += SCNPRINTF_CYC_COUNTER(info+n,BSIZE-n,compress,"c");
n += SCNPRINTF_CYC_COUNTER(info+n,BSIZE-n,decompress,"d");
n--; /* overwrite trailing comma */
diff --git a/xen/common/tmem_xen.c b/xen/common/tmem_xen.c
index 54ec09f..4725558 100644
--- a/xen/common/tmem_xen.c
+++ b/xen/common/tmem_xen.c
@@ -36,14 +36,7 @@ integer_param("tmem_lock", opt_tmem_lock);
EXPORT atomic_t freeable_page_count = ATOMIC_INIT(0);
-#ifdef COMPARE_COPY_PAGE_SSE2
-DECL_CYC_COUNTER(pg_copy1);
-DECL_CYC_COUNTER(pg_copy2);
-DECL_CYC_COUNTER(pg_copy3);
-DECL_CYC_COUNTER(pg_copy4);
-#else
DECL_CYC_COUNTER(pg_copy);
-#endif
/* these are a concurrency bottleneck, could be percpu and dynamically
* allocated iff opt_tmem_compress */
@@ -53,40 +46,12 @@ static DEFINE_PER_CPU_READ_MOSTLY(unsigned char *, workmem);
static DEFINE_PER_CPU_READ_MOSTLY(unsigned char *, dstmem);
static DEFINE_PER_CPU_READ_MOSTLY(void *, scratch_page);
-#ifdef COMPARE_COPY_PAGE_SSE2
-#include <asm/flushtlb.h> /* REMOVE ME AFTER TEST */
-#include <asm/page.h> /* REMOVE ME AFTER TEST */
-#endif
void tmh_copy_page(char *to, char*from)
{
-#ifdef COMPARE_COPY_PAGE_SSE2
- DECL_LOCAL_CYC_COUNTER(pg_copy1);
- DECL_LOCAL_CYC_COUNTER(pg_copy2);
- DECL_LOCAL_CYC_COUNTER(pg_copy3);
- DECL_LOCAL_CYC_COUNTER(pg_copy4);
- *to = *from; /* don't measure TLB misses */
- flush_area_local(to,FLUSH_CACHE|FLUSH_ORDER(0));
- flush_area_local(from,FLUSH_CACHE|FLUSH_ORDER(0));
- START_CYC_COUNTER(pg_copy1);
- copy_page_sse2(to, from); /* cold cache */
- END_CYC_COUNTER(pg_copy1);
- START_CYC_COUNTER(pg_copy2);
- copy_page_sse2(to, from); /* hot cache */
- END_CYC_COUNTER(pg_copy2);
- flush_area_local(to,FLUSH_CACHE|FLUSH_ORDER(0));
- flush_area_local(from,FLUSH_CACHE|FLUSH_ORDER(0));
- START_CYC_COUNTER(pg_copy3);
- memcpy(to, from, PAGE_SIZE); /* cold cache */
- END_CYC_COUNTER(pg_copy3);
- START_CYC_COUNTER(pg_copy4);
- memcpy(to, from, PAGE_SIZE); /* hot cache */
- END_CYC_COUNTER(pg_copy4);
-#else
DECL_LOCAL_CYC_COUNTER(pg_copy);
START_CYC_COUNTER(pg_copy);
memcpy(to, from, PAGE_SIZE);
END_CYC_COUNTER(pg_copy);
-#endif
}
#if defined(CONFIG_ARM)
--
1.7.10.4
next prev parent reply other threads:[~2013-11-08 1:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-08 1:03 [PATCH v2 00/11] tmem: some basic cleanup Bob Liu
2013-11-08 1:03 ` Bob Liu [this message]
2013-11-08 1:03 ` [PATCH v2 02/11] tmem: cleanup: drop typedef pfp_t Bob Liu
2013-11-08 1:03 ` [PATCH v2 03/11] tmem: cleanup: drop typedef tmem_cli_mfn_t Bob Liu
2013-11-08 1:03 ` [PATCH v2 04/11] tmem: cleanup: rename 'tmh_' with 'tmem_' Bob Liu
2013-11-08 1:03 ` [PATCH v2 05/11] tmem: cleanup: drop most of the typedefs Bob Liu
2013-11-08 1:03 ` [PATCH v2 06/11] tmem: cleanup: drop function tmem_alloc/free_infra Bob Liu
2013-11-08 1:03 ` [PATCH v2 07/11] tmem: cleanup: drop typedef tmem_client_t Bob Liu
2013-11-08 1:03 ` [PATCH v2 08/11] tmem: cleanup: drop useless wrap functions Bob Liu
2013-11-08 1:03 ` [PATCH v2 09/11] tmem: cleanup: drop unused function 'domain_fully_allocated' Bob Liu
2013-11-08 1:03 ` [PATCH v2 10/11] tmem: cleanup: drop useless '_subpage' wrap functions Bob Liu
2013-11-08 1:03 ` [PATCH v2 11/11] tmem: cleanup: drop useless functions Bob Liu
2014-02-07 15:48 ` Konrad Rzeszutek Wilk
2014-02-07 16:16 ` Jan Beulich
2014-02-11 7:45 ` Bob Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1383872637-15486-2-git-send-email-bob.liu@oracle.com \
--to=lliubbo@gmail.com \
--cc=JBeulich@suse.com \
--cc=bob.liu@oracle.com \
--cc=ian.campbell@citrix.com \
--cc=keir@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).