From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH RESEND 10/12] libxl: numa-sched: enable getting/specifying per-vcpu node-affinity Date: Fri, 8 Nov 2013 10:18:25 +0100 Message-ID: <1383902305.12181.7.camel@Abyss> References: <20131105142844.30446.78671.stgit@Solace> <20131105143553.30446.11558.stgit@Solace> <21115.56339.740301.681630@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4611101573149034990==" Return-path: In-Reply-To: <21115.56339.740301.681630@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: Marcus Granado , Keir Fraser , Ian Campbell , Li Yechen , George Dunlap , Andrew Cooper , Juergen Gross , xen-devel@lists.xen.org, Jan Beulich , Justin Weaver , Daniel De Graaf , Matt Wilson , Elena Ufimtseva List-Id: xen-devel@lists.xenproject.org --===============4611101573149034990== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-EPwOZTkZN/PXNNI0rQYn" --=-EPwOZTkZN/PXNNI0rQYn Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On gio, 2013-11-07 at 18:29 +0000, Ian Jackson wrote: > Dario Faggioli writes ("[PATCH RESEND 10/12] libxl: numa-sched: enable ge= tting/specifying per-vcpu node-affinity"): > > by providing the proper get/set interfaces and wiring them > > to the new libxc calls from the previous commit. > >=20 > > For the 'get' part, the node-affinity of all the vcpus of a > > domain is also reported via libxl_list_vcpu() (exactly as it > > is happening for their vcpu affinity already), adding a > > specific field to libxl_vcpuinfo. >=20 > This is a change to the libxl ABI. I think you should bump the MAJOR > number in this patch (or a previous one). >=20 Oh, do I? I may be missing something then. Every time I've done something similar to this before, I did provide the proper LIBXL_HAVE_* stuff (which this patch does), for the sake of _API_ compatibility, and that was it. :-( I've just looked up in libxl.h and found the comment block about ABI compatibility and SONAME bumping but (sorry) I'm not 100% sure I fully understand what it says. Does it (and you) mean that, since this is the first change since 4.3 that breaks ABI compatibility, I should include a patch to tools/libxl/Makefile doing something like: -MAJOR=3D4.3 +MAJOR=3D4.4 ? If yes, anything more than that? Thanks and Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-EPwOZTkZN/PXNNI0rQYn Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) iEYEABECAAYFAlJ8rGEACgkQk4XaBE3IOsQkpgCcCUyRkkmA0wr5e/6/bSiKG1Cz 4N0AoJyY/TuXLvlYUyfr4wtso/fEoid3 =ummB -----END PGP SIGNATURE----- --=-EPwOZTkZN/PXNNI0rQYn-- --===============4611101573149034990== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============4611101573149034990==--