From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kelley Nielsen Subject: [PATCH OPW 2/7] libxl: replace last invocation of LIBXL__LOG_ERROR with LOGE Date: Mon, 11 Nov 2013 07:50:09 -0800 Message-ID: <1384185014-30342-3-git-send-email-kelleynnn@gmail.com> References: <1384185014-30342-1-git-send-email-kelleynnn@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1384185014-30342-1-git-send-email-kelleynnn@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xensource.com Cc: anthony.perard@citrix.com, Ian.Campbell@citrix.com List-Id: xen-devel@lists.xenproject.org Code cleanup -- no functional changes One invocation of the macro LIBXL__LOG_ERROR remains in libxl_qmp.c. It is in a function, register_serials_chardev_callback(), that does not have a local libxl__gc gc* in the original code. Since one was added in a previous patch, change this last invocation to an invocation of LOGE. Note: This patch depends on the patch "change remaining LIBXL_LOG to LOG in libxl_qmp.c", which was submitted at 04:05, November 10, 2013. Suggested-by: Anthony PERARD Signed-off-by: Kelley Nielsen Acked-by: Ian Campbell --- tools/libxl/libxl_qmp.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tools/libxl/libxl_qmp.c b/tools/libxl/libxl_qmp.c index a181383..c6597d5 100644 --- a/tools/libxl/libxl_qmp.c +++ b/tools/libxl/libxl_qmp.c @@ -144,9 +144,8 @@ static int register_serials_chardev_callback(libxl__qmp_handler *qmp, } ret = store_serial_port_info(qmp, chardev, port_number); if (ret) { - LIBXL__LOG_ERRNO(qmp->ctx, LIBXL__LOG_ERROR, - "Failed to store serial port information" - " in xenstore"); + LOGE(ERROR, "Failed to store serial port information" + " in xenstore"); goto out; } } -- 1.8.1.2