xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Kelley Nielsen <kelleynnn@gmail.com>
To: xen-devel@lists.xensource.com
Cc: anthony.perard@citrix.com, Ian.Campbell@citrix.com
Subject: [PATCH OPW 05/11] libxl: use LOGE instead of LIBXL__LOG_ERRNO in libxl_utils.c
Date: Mon, 11 Nov 2013 15:23:54 -0800	[thread overview]
Message-ID: <1384212240-1235-6-git-send-email-kelleynnn@gmail.com> (raw)
In-Reply-To: <1384212240-1235-1-git-send-email-kelleynnn@gmail.com>

Code cleanup - no functional changes

The convenience macro LOGE has been written to take the place of
LIBXL__LOG_ERRNO. LOGE depends on the existence of a local libgl__gc
*gc. Replace two invocations of LIBXL__LOG_ERRNO, which are in
functions that already have a libxl__gc *gc present, to invocations
of the new macro.

Suggested-by: Ian Campbell <Ian.Campbell@citrix.com>
Signed-off-by: Kelley Nielsen <kelleynnn@gmail.com>
---
 tools/libxl/libxl_utils.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/tools/libxl/libxl_utils.c b/tools/libxl/libxl_utils.c
index 53ebf73..ca3406b 100644
--- a/tools/libxl/libxl_utils.c
+++ b/tools/libxl/libxl_utils.c
@@ -207,15 +207,14 @@ out:
 
 static int logrename(libxl__gc *gc, const char *old, const char *new)
 {
-    libxl_ctx *ctx = libxl__gc_owner(gc);
     int r;
 
     r = rename(old, new);
     if (r) {
         if (errno == ENOENT) return 0; /* ok */
 
-        LIBXL__LOG_ERRNO(ctx, LIBXL__LOG_ERROR, "failed to rotate logfile - could not"
-                     " rename %s to %s", old, new);
+        LOGE(ERROR, "failed to rotate logfile - "
+	     "could not rename %s to %s", old, new);
         return ERROR_FAIL;
     }
     return 0;
@@ -248,9 +247,9 @@ int libxl_create_logfile(libxl_ctx *ctx, const char *name, char **full_name)
             goto out;
     } else {
         if (errno != ENOENT)
-            LIBXL__LOG_ERRNO(ctx, LIBXL__LOG_WARNING, "problem checking existence of"
-                         " logfile %s, which might have needed to be rotated",
-                         name);
+            LOGE(WARN, "problem checking existence of logfile %s, "
+	         "which might have needed to be rotated",
+                 name);
     }
     *full_name = strdup(logfile);
     rc = 0;
-- 
1.8.1.2

  parent reply	other threads:[~2013-11-11 23:23 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-11 23:23 [PATCH 0/11 OPW] All outstanding and corrected patches Kelley Nielsen
2013-11-11 23:23 ` [PATCH OPW 01/11] libxl: change most remaining LIBXL_LOG to LOG in libxl_qmp.c Kelley Nielsen
2013-11-14 14:00   ` Anthony PERARD
2013-11-11 23:23 ` [PATCH OPW 02/11] libxl: Use new macro LOGE() " Kelley Nielsen
2013-11-11 23:23 ` [PATCH OPW 03/11] libxl: use GCSPRINTF in place of libxl_sprintf() " Kelley Nielsen
2013-11-11 23:23 ` [PATCH OPW 04/11] libxl: use GCSPRINTF instead of libxl__sprintf Kelley Nielsen
2013-11-11 23:23 ` Kelley Nielsen [this message]
2013-11-14 14:29   ` [PATCH OPW 05/11] libxl: use LOGE instead of LIBXL__LOG_ERRNO in libxl_utils.c Anthony PERARD
2013-11-11 23:23 ` [PATCH OPW 06/11] libxl: use LOG and LOGE instead of LIBXL__LOG* " Kelley Nielsen
2013-11-11 23:23 ` [PATCH OPW 07/11] libxl: use LOG instead of LIBXL__LOG " Kelley Nielsen
2013-11-11 23:23 ` [PATCH OPW 08/11] opw: libxl: add convenience macros to qmp_send() in libxl_qmp.c Kelley Nielsen
2013-11-11 23:23 ` [PATCH OPW 09/11] opw: libxl: use macro CTX " Kelley Nielsen
2013-11-11 23:23 ` [PATCH OPW 10/11] opw: libxl: use macro GCNEW " Kelley Nielsen
2013-11-11 23:24 ` [PATCH OPW 11/11] opw: libxl: use CTX macro in libxl_utils.c Kelley Nielsen
2013-11-12 17:26 ` [PATCH 0/11 OPW] All outstanding and corrected patches Matt Wilson
2013-11-19 14:29 ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1384212240-1235-6-git-send-email-kelleynnn@gmail.com \
    --to=kelleynnn@gmail.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=anthony.perard@citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).