xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: xen-devel@lists.xen.org
Cc: julien.grall@linaro.org, tim@xen.org,
	Ian Campbell <ian.campbell@citrix.com>,
	stefano.stabellini@eu.citrix.com
Subject: [PATCH v4 08/17] xen: arm: implement arch_set_info_guest for 64-bit vcpus
Date: Tue, 12 Nov 2013 17:39:11 +0000	[thread overview]
Message-ID: <1384277960-14426-8-git-send-email-ian.campbell@citrix.com> (raw)
In-Reply-To: <1384277936.10204.111.camel@kazak.uk.xensource.com>

This all seems too easy...

Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Acked-by: Julien Grall <julien.grall@linaro.org>
---
 xen/arch/arm/domain.c |   64 ++++++++++++++++++++++++++++++++++++++-----------
 1 file changed, 50 insertions(+), 14 deletions(-)

diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
index cb0424d..5ff7adf 100644
--- a/xen/arch/arm/domain.c
+++ b/xen/arch/arm/domain.c
@@ -550,7 +550,7 @@ void arch_domain_destroy(struct domain *d)
     free_xenheap_page(d->shared_info);
 }
 
-static int is_guest_psr(uint32_t psr)
+static int is_guest_pv32_psr(uint32_t psr)
 {
     switch (psr & PSR_MODE_MASK)
     {
@@ -569,6 +569,29 @@ static int is_guest_psr(uint32_t psr)
     }
 }
 
+
+#ifdef CONFIG_ARM_64
+static int is_guest_pv64_psr(uint32_t psr)
+{
+    if ( psr & PSR_MODE_BIT )
+        return 0;
+
+    switch (psr & PSR_MODE_MASK)
+    {
+    case PSR_MODE_EL1h:
+    case PSR_MODE_EL1t:
+    case PSR_MODE_EL0t:
+        return 1;
+    case PSR_MODE_EL3h:
+    case PSR_MODE_EL3t:
+    case PSR_MODE_EL2h:
+    case PSR_MODE_EL2t:
+    default:
+        return 0;
+    }
+}
+#endif
+
 /*
  * Initialise VCPU state. The context can be supplied by either the
  * toolstack (XEN_DOMCTL_setvcpucontext) or the guest
@@ -580,19 +603,32 @@ int arch_set_info_guest(
     struct vcpu_guest_context *ctxt = c.nat;
     struct vcpu_guest_core_regs *regs = &c.nat->user_regs;
 
-    if ( !is_guest_psr(regs->cpsr) )
-        return -EINVAL;
-
-    if ( regs->spsr_svc && !is_guest_psr(regs->spsr_svc) )
-        return -EINVAL;
-    if ( regs->spsr_abt && !is_guest_psr(regs->spsr_abt) )
-        return -EINVAL;
-    if ( regs->spsr_und && !is_guest_psr(regs->spsr_und) )
-        return -EINVAL;
-    if ( regs->spsr_irq && !is_guest_psr(regs->spsr_irq) )
-        return -EINVAL;
-    if ( regs->spsr_fiq && !is_guest_psr(regs->spsr_fiq) )
-        return -EINVAL;
+    if ( is_pv32_domain(v->domain) )
+    {
+        if ( !is_guest_pv32_psr(regs->cpsr) )
+            return -EINVAL;
+
+        if ( regs->spsr_svc && !is_guest_pv32_psr(regs->spsr_svc) )
+            return -EINVAL;
+        if ( regs->spsr_abt && !is_guest_pv32_psr(regs->spsr_abt) )
+            return -EINVAL;
+        if ( regs->spsr_und && !is_guest_pv32_psr(regs->spsr_und) )
+            return -EINVAL;
+        if ( regs->spsr_irq && !is_guest_pv32_psr(regs->spsr_irq) )
+            return -EINVAL;
+        if ( regs->spsr_fiq && !is_guest_pv32_psr(regs->spsr_fiq) )
+            return -EINVAL;
+    }
+#ifdef CONFIG_ARM_64
+    else
+    {
+        if ( !is_guest_pv64_psr(regs->cpsr) )
+            return -EINVAL;
+
+        if ( regs->spsr_el1 && !is_guest_pv64_psr(regs->spsr_el1) )
+            return -EINVAL;
+    }
+#endif
 
     vcpu_regs_user_to_hyp(v, regs);
 
-- 
1.7.10.4

  parent reply	other threads:[~2013-11-12 17:39 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-12 17:38 [PATCH v4 00/17] xen: arm: 64-bit guest support and domU FDT autogeneration Ian Campbell
2013-11-12 17:39 ` [PATCH v4 01/17] xen: update config.{sub, guess} for arm64 Ian Campbell
2013-11-12 17:46   ` Ian Campbell
2013-11-12 17:39 ` [PATCH v4 02/17] xen: arm: Report aarch64 capability Ian Campbell
2013-11-12 17:39 ` [PATCH v4 03/17] xen: arm: Add comment regard arm64 zImage v0 vs v1 Ian Campbell
2013-11-12 17:39 ` [PATCH v4 04/17] xen: arm: allocate dom0 memory separately from preparing the dtb Ian Campbell
2013-11-12 17:47   ` Ian Campbell
2013-11-12 17:39 ` [PATCH v4 05/17] xen: arm: add enable-method to cpu nodes for arm64 guests Ian Campbell
2013-11-12 17:39 ` [PATCH v4 06/17] xen: arm: include header for for arch_do_{sys, dom}ctl prototype Ian Campbell
2013-11-12 19:18   ` Stefano Stabellini
2013-11-12 17:39 ` [PATCH v4 07/17] xen: arm: implement XEN_DOMCTL_set_address_size Ian Campbell
2013-11-12 17:39 ` Ian Campbell [this message]
2013-11-12 17:39 ` [PATCH v4 09/17] tools: check for libfdt when building for ARM Ian Campbell
2013-11-12 17:39 ` [PATCH v4 10/17] xen: arm: define guest virtual platform in API headers Ian Campbell
2013-11-12 19:31   ` Stefano Stabellini
2013-11-12 19:45   ` Julien Grall
2013-11-13 10:19     ` Ian Campbell
2013-11-12 17:39 ` [PATCH v4 11/17] libxc: arm: rename various bits of zimage load with 32 suffix Ian Campbell
2013-11-12 17:39 ` [PATCH v4 12/17] libxc: allow caller to specify guest rambase rather than hardcoding Ian Campbell
2013-11-12 17:39 ` [PATCH v4 13/17] libxc: arm: allow passing a device tree blob to the guest Ian Campbell
2013-11-12 18:10   ` Ian Jackson
2013-11-12 19:37   ` Stefano Stabellini
2013-11-13 10:21     ` Ian Campbell
2013-11-13 12:01       ` Stefano Stabellini
2013-11-13 12:16         ` Ian Campbell
2013-11-13 13:42           ` Julien Grall
2013-11-13 13:46             ` Ian Campbell
2013-11-13 13:51               ` Julien Grall
2013-11-12 17:39 ` [PATCH v4 14/17] libxc: support for arm64 Image format Ian Campbell
2013-11-12 17:39 ` [PATCH v4 15/17] libxc: arm64 vcpu initialisation Ian Campbell
2013-11-12 17:39 ` [PATCH v4 16/17] libxl: build a device tree for ARM guests Ian Campbell
2013-11-12 18:06   ` Ian Jackson
2013-11-13 10:04     ` Ian Campbell
2013-11-12 19:51   ` Stefano Stabellini
2013-11-13 10:26     ` Ian Campbell
2013-11-12 19:59   ` Julien Grall
2013-11-13 10:23     ` Ian Campbell
2013-11-12 17:39 ` [PATCH v4 17/17] libxl: Coding Style cleanups to libxl_dom.c Ian Campbell
2013-11-12 18:08   ` Ian Jackson
2013-11-13 10:05     ` Ian Campbell
2013-11-12 17:43 ` [PATCH v4 00/17] xen: arm: 64-bit guest support and domU FDT autogeneration Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1384277960-14426-8-git-send-email-ian.campbell@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=julien.grall@linaro.org \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).