From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH RESEND 09/12] libxc: numa-sched: enable getting/specifying per-vcpu node-affinity Date: Tue, 12 Nov 2013 22:36:28 +0100 Message-ID: <1384292188.16918.30.camel@Solace> References: <20131105142844.30446.78671.stgit@Solace> <20131105143542.30446.5398.stgit@Solace> <20131112160144.GB11354@phenom.dumpdata.com> <1384281624.16918.26.camel@Solace> <20131112191310.GA12345@phenom.dumpdata.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7265743847956447820==" Return-path: In-Reply-To: <20131112191310.GA12345@phenom.dumpdata.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Konrad Rzeszutek Wilk Cc: Marcus Granado , Keir Fraser , Ian Campbell , Li Yechen , George Dunlap , Andrew Cooper , Juergen Gross , Ian Jackson , xen-devel@lists.xen.org, Jan Beulich , Justin Weaver , Daniel De Graaf , Matt Wilson , Elena Ufimtseva List-Id: xen-devel@lists.xenproject.org --===============7265743847956447820== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-f7ostWoCtwkaOAmb/ccP" --=-f7ostWoCtwkaOAmb/ccP Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On mar, 2013-11-12 at 14:13 -0500, Konrad Rzeszutek Wilk wrote: > On Tue, Nov 12, 2013 at 07:40:24PM +0100, Dario Faggioli wrote: > > Mmm... As George said already, that is the most common behavior in > > libxc... If we want something different, we should really write it down > > somewhere (or has that happened already and I'm missing it?). >=20 > I was under the impression that was it - but I am probably misremembering > Ian's comments and now sowing disinformation. >=20 Well, it may well have been me having missed that, so, really, no big deal at all. :-) > > > > + set_xen_guest_handle(domctl.u.vcpuaffinity.map.bitmap, local); > > > > + domctl.u.vcpuaffinity.map.nr_bits =3D nodesize * 8; > > >=20 > > > Could the 8 be replaced by a sizeof? > > > > > I guess it could... What was it that you had in mind in particular? > >=20 > > Personally, I consider the names 'bitmap' and 'nr_bits' talking enough > > to feel comfortable with the 8... To the point that I think the > > following would be even less readable: > >=20 > > domctl.u.vcpuaffinity.map.nr_bits =3D nodesize *=20 > > sizeof(domctl.u.vcpuaffinity.cpumap.bitmap); >=20 > Eww. That is worst. Somehow I assumed you could just do 'sizeof(unsigned = long long)' > or such. or some #define for this magic number. > Maybe I can... I'll look into that (although no promises, ok? :-P). This is all about playing games with uint8_t and array of them with weird sizes... Again, I'll see if I can come up with something... Thanks and Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-f7ostWoCtwkaOAmb/ccP Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) iEYEABECAAYFAlKCn10ACgkQk4XaBE3IOsRCCgCbBnQGrdKnNTfaJCfWHMJAZiK2 Cs4AmwfM8Orvy+StSAXz93uRJvEzQ2a0 =BP1s -----END PGP SIGNATURE----- --=-f7ostWoCtwkaOAmb/ccP-- --===============7265743847956447820== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============7265743847956447820==--