From: Ian Campbell <ian.campbell@citrix.com>
To: xen-devel@lists.xen.org
Cc: julien.grall@linaro.org, tim@xen.org,
Ian Campbell <ian.campbell@citrix.com>,
stefano.stabellini@eu.citrix.com
Subject: [PATCH v5 02/19] xen: arm: drop LDFLAGS_DIRECT emulation specification.
Date: Wed, 13 Nov 2013 18:11:08 +0000 [thread overview]
Message-ID: <1384366285-29277-2-git-send-email-ian.campbell@citrix.com> (raw)
In-Reply-To: <1384366234.29080.8.camel@kazak.uk.xensource.com>
The current -maarch64elf fails when cross-building arm64 on Ubuntu Raring due
to a missing file "ldscripts/aarch64elf.xr". This is undoubtedly an Ubuntu gcc
bug, hwever when investigating I found that this option was not necessary at
all since we provide an explicit linker script when linking the hypervisor
(AFAICT all -m<foo> does is override the default linker script).
LDFLAGS_DIRECT is also used when linking the intermediate built-in.o files but
-m<emulatin> is not needed for this since it isn't linking the final image and
we are calling the linker with the correct, cross if necessary, name.
However it does appear to be potentially useful to supply -EL in both cases to
ensure that we get little endian images. (I just happened to spot that Linux
does this, for both arm and arm64, although I expect we are unlikely to trip
over such toolchains these days).
Tested with cross-builds of arm32 and arm64 as well as a native arm32 build.
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
---
config/arm32.mk | 5 +----
config/arm64.mk | 2 +-
2 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/config/arm32.mk b/config/arm32.mk
index f64f0c1..683531c 100644
--- a/config/arm32.mk
+++ b/config/arm32.mk
@@ -10,9 +10,6 @@ CFLAGS += -marm
HAS_PL011 := y
# Use only if calling $(LD) directly.
-#LDFLAGS_DIRECT_OpenBSD = _obsd
-#LDFLAGS_DIRECT_FreeBSD = _fbsd
-LDFLAGS_DIRECT_Linux = _linux
-LDFLAGS_DIRECT += -marmelf$(LDFLAGS_DIRECT_$(XEN_OS))_eabi
+LDFLAGS_DIRECT += -EL
CONFIG_LOAD_ADDRESS ?= 0x80000000
diff --git a/config/arm64.mk b/config/arm64.mk
index b2457eb..55b16da 100644
--- a/config/arm64.mk
+++ b/config/arm64.mk
@@ -7,6 +7,6 @@ CFLAGS += #-marm -march= -mcpu= etc
HAS_PL011 := y
# Use only if calling $(LD) directly.
-LDFLAGS_DIRECT += -maarch64elf
+LDFLAGS_DIRECT += -EL
CONFIG_LOAD_ADDRESS ?= 0x80000000
--
1.7.10.4
next prev parent reply other threads:[~2013-11-13 18:11 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-13 18:10 [PATCH v5 00/17] xen: arm: 64-bit guest support and domU FDT autogeneration Ian Campbell
2013-11-13 18:11 ` [PATCH v5 01/19] HACK Ian Campbell
2013-11-13 18:15 ` Julien Grall
2013-11-13 20:15 ` Ian Campbell
2013-11-13 18:11 ` Ian Campbell [this message]
2013-11-13 21:26 ` [PATCH v5 02/19] xen: arm: drop LDFLAGS_DIRECT emulation specification Julien Grall
2013-11-14 8:16 ` Ian Campbell
2013-11-13 18:11 ` [PATCH v5 03/19] xen: update config.{sub, guess} for arm64 Ian Campbell
2013-11-13 18:11 ` [PATCH v5 04/19] xen: arm: Report aarch64 capability Ian Campbell
2013-11-13 18:11 ` [PATCH v5 05/19] xen: arm: Add comment regard arm64 zImage v0 vs v1 Ian Campbell
2013-11-13 18:11 ` [PATCH v5 06/19] xen: arm: move dom0 gic and timer device tree nodes under /xen/ Ian Campbell
2013-11-13 18:28 ` Stefano Stabellini
2013-11-13 20:18 ` Ian Campbell
2013-11-14 12:22 ` Stefano Stabellini
2013-11-19 9:52 ` Ian Campbell
2013-11-13 21:31 ` Julien Grall
2013-11-14 8:18 ` Ian Campbell
2013-11-13 18:11 ` [PATCH v5 07/19] xen: arm: allocate dom0 memory separately from preparing the dtb Ian Campbell
2013-11-13 19:21 ` Stefano Stabellini
2013-11-13 20:18 ` Ian Campbell
2013-11-14 12:22 ` Stefano Stabellini
2013-11-13 21:34 ` Julien Grall
2013-11-14 8:23 ` Ian Campbell
2013-11-14 0:52 ` Julien Grall
2013-11-14 8:25 ` Ian Campbell
2013-11-13 18:11 ` [PATCH v5 08/19] xen: arm: add enable-method to cpu nodes for arm64 guests Ian Campbell
2013-11-13 18:11 ` [PATCH v5 09/19] xen: arm: include header for for arch_do_{sys, dom}ctl prototype Ian Campbell
2013-11-13 18:11 ` [PATCH v5 10/19] xen: arm: implement XEN_DOMCTL_set_address_size Ian Campbell
2013-11-13 18:11 ` [PATCH v5 11/19] xen: arm: implement arch_set_info_guest for 64-bit vcpus Ian Campbell
2013-11-13 18:11 ` [PATCH v5 12/19] tools: check for libfdt when building for ARM Ian Campbell
2013-11-13 18:11 ` [PATCH v5 13/19] xen: arm: define guest virtual platform in API headers Ian Campbell
2013-11-13 18:11 ` [PATCH v5 14/19] libxc: arm: rename various bits of zimage load with 32 suffix Ian Campbell
2013-11-13 18:11 ` [PATCH v5 15/19] libxc: allow caller to specify guest rambase rather than hardcoding Ian Campbell
2013-11-13 18:11 ` [PATCH v5 16/19] libxc: arm: allow passing a device tree blob to the guest Ian Campbell
2013-11-14 0:47 ` Julien Grall
2013-11-19 12:36 ` Ian Campbell
2013-11-13 18:11 ` [PATCH v5 17/19] libxc: support for arm64 Image format Ian Campbell
2013-11-14 1:17 ` Julien Grall
2013-11-19 12:39 ` Ian Campbell
2013-11-13 18:11 ` [PATCH v5 18/19] libxc: arm64 vcpu initialisation Ian Campbell
2013-11-13 18:11 ` [PATCH v5 19/19] libxl: build a device tree for ARM guests Ian Campbell
2013-11-13 18:19 ` Stefano Stabellini
2013-11-14 1:04 ` Julien Grall
2013-11-14 8:28 ` Ian Campbell
2013-11-14 12:17 ` Julien Grall
2013-11-14 11:50 ` Ian Jackson
2013-11-14 12:17 ` Stefano Stabellini
2013-11-14 12:24 ` Julien Grall
2013-11-14 12:45 ` Ian Campbell
2013-11-14 14:01 ` Stefano Stabellini
2013-11-19 10:30 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1384366285-29277-2-git-send-email-ian.campbell@citrix.com \
--to=ian.campbell@citrix.com \
--cc=julien.grall@linaro.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).