From: Nathan Studer <nate.studer@dornerworks.com>
To: xen-devel@lists.xen.org
Cc: George Dunlap <george.dunlap@eu.citrix.com>,
Nate Studer <nate.studer@dornerworks.com>,
lwcheng@cs.hku.hk
Subject: [Patch] credit: Update other parameters when setting tslice_ms
Date: Wed, 13 Nov 2013 16:49:49 -0500 [thread overview]
Message-ID: <1384379389-3661-1-git-send-email-nate.studer@dornerworks.com> (raw)
From: Nate Studer <nate.studer@dornerworks.com>
Add a utility function to update the rest of the timeslice
accounting fields when updating the timeslice of the
credit scheduler, so that capped CPUs behave correctly.
Before this patch changing the timeslice to a value higher
than the default would result in a domain not utilizing
its full capacity and changing the timeslice to a value
lower than the default would result in a domain exceeding
its capacity.
Signed-off-by: Nate Studer <nate.studer@dornerworks.com>
---
xen/common/sched_credit.c | 20 +++++++++++++-------
1 file changed, 13 insertions(+), 7 deletions(-)
mode change 100644 => 100755 xen/common/sched_credit.c
diff --git a/xen/common/sched_credit.c b/xen/common/sched_credit.c
old mode 100644
new mode 100755
index 28dafcf..db5512e
--- a/xen/common/sched_credit.c
+++ b/xen/common/sched_credit.c
@@ -1071,6 +1071,17 @@ csched_dom_cntl(
return 0;
}
+static inline void
+__csched_set_tslice(struct csched_private *prv, unsigned timeslice)
+{
+ prv->tslice_ms = timeslice;
+ prv->ticks_per_tslice = CSCHED_TICKS_PER_TSLICE;
+ if ( prv->tslice_ms < prv->ticks_per_tslice )
+ prv->ticks_per_tslice = 1;
+ prv->tick_period_us = prv->tslice_ms * 1000 / prv->ticks_per_tslice;
+ prv->credits_per_tslice = CSCHED_CREDITS_PER_MSEC * prv->tslice_ms;
+}
+
static int
csched_sys_cntl(const struct scheduler *ops,
struct xen_sysctl_scheduler_op *sc)
@@ -1089,7 +1100,7 @@ csched_sys_cntl(const struct scheduler *ops,
|| params->ratelimit_us < XEN_SYSCTL_SCHED_RATELIMIT_MIN))
|| MICROSECS(params->ratelimit_us) > MILLISECS(params->tslice_ms) )
goto out;
- prv->tslice_ms = params->tslice_ms;
+ __csched_set_tslice(prv, params->tslice_ms);
prv->ratelimit_us = params->ratelimit_us;
/* FALLTHRU */
case XEN_SYSCTL_SCHEDOP_getinfo:
@@ -1899,12 +1910,7 @@ csched_init(struct scheduler *ops)
sched_credit_tslice_ms = CSCHED_DEFAULT_TSLICE_MS;
}
- prv->tslice_ms = sched_credit_tslice_ms;
- prv->ticks_per_tslice = CSCHED_TICKS_PER_TSLICE;
- if ( prv->tslice_ms < prv->ticks_per_tslice )
- prv->ticks_per_tslice = 1;
- prv->tick_period_us = prv->tslice_ms * 1000 / prv->ticks_per_tslice;
- prv->credits_per_tslice = CSCHED_CREDITS_PER_MSEC * prv->tslice_ms;
+ __csched_set_tslice(prv, sched_credit_tslice_ms);
if ( MICROSECS(sched_ratelimit_us) > MILLISECS(sched_credit_tslice_ms) )
{
--
1.7.9.5
next reply other threads:[~2013-11-13 21:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-13 21:49 Nathan Studer [this message]
2013-11-15 12:23 ` [Patch] credit: Update other parameters when setting tslice_ms Nate Studer
2013-11-15 12:25 ` George Dunlap
2013-11-15 13:53 ` Dario Faggioli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1384379389-3661-1-git-send-email-nate.studer@dornerworks.com \
--to=nate.studer@dornerworks.com \
--cc=george.dunlap@eu.citrix.com \
--cc=lwcheng@cs.hku.hk \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).