Re: [PATCH v2 1/7] xen: vNUMA support for guests.

[Dario Faggioli <dario.faggioli@citrix.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1321 bytes --]

On gio, 2013-11-14 at 11:48 +0000, David Vrabel wrote:
> On 14/11/13 03:26, Elena Ufimtseva wrote:
> > +/* 
> > + * Memory ranges can be used to define
> > + * vNUMA memory node boundaries by the 
> > + * linked list. As of now, only one range
> > + * per domain is suported.
> > + */
> > +
> > +struct vmemrange {
> > +    uint64_t start, end;
> > +    struct vmemrange *next;
> 
> I think this probably wants to be an index into the vmemrange array in
> struct vnuma_topology_info.  It certainly cannot be a bare pointer like
> this.
> 
I think Elena is aiming at a liked list, and so there really is no such
thing as a vmemrange array. This is (probably) because right now only
one memory range is supported, and thus it sounds a bit too much to have
an array there already (e.g., how big?), but at the same time she wanted
to be sure to leave room for future extensions (namely, multiple memory
ranges in each node).

So, if we can ask, with that in mind, what do you think the best ABI
would be?

Thanks and Regards,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel