From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v2 11/16] libxc: get and set soft and hard affinity Date: Thu, 14 Nov 2013 17:41:52 +0100 Message-ID: <1384447312.29902.174.camel@Abyss> References: <20131113190852.18086.5437.stgit@Solace> <20131113191242.18086.73258.stgit@Solace> <5284EE61.5000707@eu.citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5657618698066793890==" Return-path: In-Reply-To: <5284EE61.5000707@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: George Dunlap Cc: Marcus Granado , Keir Fraser , Ian Campbell , Li Yechen , Andrew Cooper , Juergen Gross , Ian Jackson , xen-devel@lists.xen.org, Jan Beulich , Justin Weaver , Matt Wilson , Elena Ufimtseva List-Id: xen-devel@lists.xenproject.org --===============5657618698066793890== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-DnQoT6bL6MVfip+6Yb+4" --=-DnQoT6bL6MVfip+6Yb+4 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On gio, 2013-11-14 at 15:38 +0000, George Dunlap wrote: > On 13/11/13 19:12, Dario Faggioli wrote: > > by using the new flag introduced in the parameters of > > DOMCTL_{get,set}_vcpuaffinity. > > > > This happens in two new xc calls: xc_vcpu_setaffinity_hard() > > and xc_vcpu_setaffinity_soft() (an in the corresponding > > getters, of course). >=20 > Personally I think: > * You should be able to set both HARD and SOFT flags, in which case it= =20 > will set both hard and soft affinities > Ok. Just to be sure, you mean that, if I specify both flags, both hard and soft affinity will be set to the same cpumap, right? > * You should expose the "flags" to the xc caller, so that the caller can= =20 > set either one or both. >=20 Ok. > > The existing xc_vcpu_{set,get}affinity() call is also retained, > > with the following behavior: > > > > * xc_vcpu_setaffinity() sets both the hard and soft affinity; > > * xc_vcpu_getaffinity() gets the hard affinity. > > > > This is mainly for backward compatibility reasons, i.e., trying > > not to break existing callers/users. >=20 > The xc interface isn't stable, right? Couldn't we just change the=20 > callers (presumably just xend and libxl)? > In tree, yes, those ones plus something in tools/ocaml/libs/xc/xenctrl_stubs.c. I'll do it that way. Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-DnQoT6bL6MVfip+6Yb+4 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) iEYEABECAAYFAlKE/VAACgkQk4XaBE3IOsQSjACdGMoYImDw/AxFRGf/5Fjg+L7g xs4An0ViFO/13/u11Jb2NXu3EQKiFT5e =+JVd -----END PGP SIGNATURE----- --=-DnQoT6bL6MVfip+6Yb+4-- --===============5657618698066793890== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============5657618698066793890==--