From: Julien Grall <julien.grall@linaro.org>
To: xen-devel@lists.xenproject.org
Cc: stefano.stabellini@eu.citrix.com, tim@xen.org,
ian.campbell@citrix.com, Julien Grall <julien.grall@linaro.org>,
patches@linaro.org
Subject: [PATCH] xen/arm: Panic if we are unable to initialize platform timer
Date: Fri, 15 Nov 2013 15:27:37 +0000 [thread overview]
Message-ID: <1384529257-7590-3-git-send-email-julien.grall@linaro.org> (raw)
In-Reply-To: <1384529257-7590-1-git-send-email-julien.grall@linaro.org>
The caller of xen_init_time, start_xen, doesn't check the return value
of the function. Xen will silently ignore the error and continue.
Signed-off-by: Julien Grall <julien.grall@linaro.org>
---
xen/arch/arm/time.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/arch/arm/time.c b/xen/arch/arm/time.c
index a30d422..938995d 100644
--- a/xen/arch/arm/time.c
+++ b/xen/arch/arm/time.c
@@ -132,7 +132,7 @@ int __init init_xen_time(void)
res = platform_init_time();
if ( res )
- return res;
+ panic("Timer: Cannot initialize platform timer\n");
/* Check that this CPU supports the Generic Timer interface */
if ( !cpu_has_gentimer )
--
1.8.3.1
next prev parent reply other threads:[~2013-11-15 15:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-15 15:27 [PATCH] xen/arm: ioremap_attr: return NULL is __vmap failed Julien Grall
2013-11-15 15:27 ` [PATCH] xen/arm: Panic if platform initialization failed Julien Grall
2013-11-15 15:59 ` Stefano Stabellini
2013-11-19 14:50 ` Ian Campbell
2013-11-15 15:27 ` Julien Grall [this message]
2013-11-15 15:58 ` [PATCH] xen/arm: Panic if we are unable to initialize platform timer Stefano Stabellini
2013-11-19 14:47 ` Ian Campbell
2013-11-19 16:39 ` Julien Grall
2013-11-15 15:45 ` [PATCH] xen/arm: ioremap_attr: return NULL is __vmap failed Andrew Cooper
2013-11-15 16:04 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1384529257-7590-3-git-send-email-julien.grall@linaro.org \
--to=julien.grall@linaro.org \
--cc=ian.campbell@citrix.com \
--cc=patches@linaro.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).