From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: [PATCH] xen/arm: Panic if we are unable to initialize platform timer Date: Fri, 15 Nov 2013 15:27:37 +0000 Message-ID: <1384529257-7590-3-git-send-email-julien.grall@linaro.org> References: <1384529257-7590-1-git-send-email-julien.grall@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1VhLJV-00031u-K2 for xen-devel@lists.xenproject.org; Fri, 15 Nov 2013 15:28:05 +0000 Received: by mail-wi0-f177.google.com with SMTP id hq4so1145012wib.10 for ; Fri, 15 Nov 2013 07:28:04 -0800 (PST) In-Reply-To: <1384529257-7590-1-git-send-email-julien.grall@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xenproject.org Cc: stefano.stabellini@eu.citrix.com, tim@xen.org, ian.campbell@citrix.com, Julien Grall , patches@linaro.org List-Id: xen-devel@lists.xenproject.org The caller of xen_init_time, start_xen, doesn't check the return value of the function. Xen will silently ignore the error and continue. Signed-off-by: Julien Grall --- xen/arch/arm/time.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/arm/time.c b/xen/arch/arm/time.c index a30d422..938995d 100644 --- a/xen/arch/arm/time.c +++ b/xen/arch/arm/time.c @@ -132,7 +132,7 @@ int __init init_xen_time(void) res = platform_init_time(); if ( res ) - return res; + panic("Timer: Cannot initialize platform timer\n"); /* Check that this CPU supports the Generic Timer interface */ if ( !cpu_has_gentimer ) -- 1.8.3.1