From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH] xend: do not polling vcpus info if guest state is not RUNNING or PAUSED Date: Tue, 19 Nov 2013 08:06:35 +0100 Message-ID: <1384844795.19880.5.camel@Abyss> References: <528B017D.5020202@oracle.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6604424729853690478==" Return-path: In-Reply-To: <528B017D.5020202@oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Joe Jin Cc: Keir Fraser , xen-devel , ian.jackson@eu.citrix.com, Ian Campbell List-Id: xen-devel@lists.xenproject.org --===============6604424729853690478== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-swXZQI8jypDwYS7uyIs9" --=-swXZQI8jypDwYS7uyIs9 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On mar, 2013-11-19 at 14:13 +0800, Joe Jin wrote: > When created new guest on NUMA server, xend tried to get the best node by > calculated all vcpus info, the race is if other geust is rebooting, the > guest in the list when entered find_relaxed_node(), but when call > getVCPUInfo() the guest be terminated, then getVCPUInfo() will fail with > below error: >=20 > [2013-09-04 20:01:26 6254] ERROR (XendDomainInfo:496) VM start failed > Traceback (most recent call last): > File "/usr/lib64/python2.4/site-packages/xen/xend/XendDomainInfo.py", l= ine 482, in start > XendTask.log_progress(31, 60, self._initDomain) > File "/usr/lib64/python2.4/site-packages/xen/xend/XendTask.py", line 20= 9, in log_progress > retval =3D func(*args, **kwds) > File "/usr/lib64/python2.4/site-packages/xen/xend/XendDomainInfo.py", l= ine 2918, in _initDomain > node =3D self._setCPUAffinity() > File "/usr/lib64/python2.4/site-packages/xen/xend/XendDomainInfo.py", l= ine 2835, in _setCPUAffinity > best_node =3D find_relaxed_node(candidate_node_list)[0] > File "/usr/lib64/python2.4/site-packages/xen/xend/XendDomainInfo.py", l= ine 2803, in find_relaxed_node > cpuinfo =3D dom.getVCPUInfo() > File "/usr/lib64/python2.4/site-packages/xen/xend/XendDomainInfo.py", l= ine 1600, in getVCPUInfo > raise XendError(str(exn)) > XendError: (3, 'No such process') >=20 > This patch will let find_relaxed_node() only polling the RUNNING or PAUSE= D > guest vpus info to avoid the race. >=20 > Signed-off-by: Joe Jin > The idea looks ok. Unfortunately, I know nothing of xend, thus I really don't feel comfortable enough to provide a formal Ack. Basically, I don't know whether this patch is the best way to fix the issue, if there are other ways, etc, but the problem certainly exist and the solution sounds sound. :-) Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-swXZQI8jypDwYS7uyIs9 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) iEYEABECAAYFAlKLDfsACgkQk4XaBE3IOsTAlQCdH1d+1JKn82TRbxFaxZUOOOgC KWMAnidCTxCddEMGkkOXPMt3uO4UBWTb =96pV -----END PGP SIGNATURE----- --=-swXZQI8jypDwYS7uyIs9-- --===============6604424729853690478== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============6604424729853690478==--