From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v3 02/14] libxl: sanitize error handling in libxl_get_max_{cpus, nodes} Date: Tue, 19 Nov 2013 13:34:32 +0100 Message-ID: <1384864472.19880.70.camel@Abyss> References: <20131118175544.31002.79574.stgit@Solace> <20131118181646.31002.55372.stgit@Solace> <528B5881.2070508@eu.citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7175013503785857090==" Return-path: In-Reply-To: <528B5881.2070508@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: George Dunlap Cc: Marcus Granado , Keir Fraser , Ian Campbell , Li Yechen , Andrew Cooper , Juergen Gross , Ian Jackson , xen-devel@lists.xen.org, Jan Beulich , Justin Weaver , Matt Wilson , Elena Ufimtseva List-Id: xen-devel@lists.xenproject.org --===============7175013503785857090== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-PIClbJfnnlZaA5HW92qM" --=-PIClbJfnnlZaA5HW92qM Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On mar, 2013-11-19 at 12:24 +0000, George Dunlap wrote: > On 11/18/2013 06:16 PM, Dario Faggioli wrote: > > as well as both error handling and logging in libxl_cpu_bitmap_alloc > > and libxl_node_bitmap_alloc. > > > > Now libxl_get_max_{cpus,nodes} either return a positive number, or > > a libxl error code. Thanks to that, it is possible to fix loggig for > > the two bitmap allocation functions, which now happens _inside_ the > > functions themselves, and report what happens more accurately. > > > > Signed-off-by: Dario Faggioli >=20 > Reviewed-by: George Dunlap >=20 Thanks. > > diff --git a/tools/libxl/libxl_utils.c b/tools/libxl/libxl_utils.c > > index 682f874..2a51c9c 100644 > > --- a/tools/libxl/libxl_utils.c > > +++ b/tools/libxl/libxl_utils.c > > @@ -645,6 +645,46 @@ char *libxl_bitmap_to_hex_string(libxl_ctx *ctx, c= onst libxl_bitmap *bitmap) > > return q; > > } > > > > +inline int libxl_cpu_bitmap_alloc(libxl_ctx *ctx, > > + libxl_bitmap *cpumap, > > + int max_cpus) >=20 > Stray 'inline'. :-) >=20 Wow... How did he manage to survive? I mean, I killed his 'static' buddy but kept him? I guess I'm getting too old for late night hacking sessions! :-P Anyway, let's see how the rest of the review goes. If I have to resend, I will fix this. Otherwise I can just resend this patch, or do whatever the maintainers/committers are most comfortable with. Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-PIClbJfnnlZaA5HW92qM Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) iEYEABECAAYFAlKLWtgACgkQk4XaBE3IOsReAQCfWJmy5PPKwYSg7S3w6IUppIuU 7GMAnRvwJ9tPGkstLP1eJMpTeqHPm0Nn =7odY -----END PGP SIGNATURE----- --=-PIClbJfnnlZaA5HW92qM-- --===============7175013503785857090== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============7175013503785857090==--