xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: Shriram Rajagopalan <rshriram@cs.ubc.ca>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Ian Jackson <ian.jackson@eu.citrix.com>,
	George Dunlap <George.Dunlap@citrix.com>,
	xen-devel@lists.xen.org, Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [PATCH 0 of 4 V5] Remus/Libxl: Network buffering support
Date: Tue, 19 Nov 2013 16:23:38 +0000	[thread overview]
Message-ID: <1384878218.16252.27.camel@hastur.hellion.org.uk> (raw)
In-Reply-To: <patchbomb.1384804983@athos.nss.cs.ubc.ca>

On Mon, 2013-11-18 at 12:03 -0800, Shriram Rajagopalan wrote:
> This patch series adds support for network buffering in the Remus
> codebase in libxl.  NB: This series does not contain the
> bug fix related to usleep calls in libxl__domain_suspend.
> I will send it out later as a separate series.
> 
> Changes in V5:
> 
> Merge hotplug script patch (2/5) and hotplug script setup/teardown
> patch (3/5) into a single patch.

This has dropped to 4 patches vs 7 in v4. One of the delta is this
merging, what happened to the other two? Especially given that Ian J
asked for #7 to be split last time around.

>From an initial glance this looks like code this time around is that
right? I know some stuff is to come later but IIRC that wasn't in the
previous series either.

>From a release point of view (George CCd) it looks like it only touches
Remus code other than a few little changes in the generic save/restore
code which are guarded by (in effect) if (remus). Is that correct?

If the only risk is to Remus users and the plus side is a far more
useful Remus then I'd say we should make a freeze exception, subject to
the code being reviewed of course.

Ian.

  parent reply	other threads:[~2013-11-19 16:23 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-18 20:03 [PATCH 0 of 4 V5] Remus/Libxl: Network buffering support Shriram Rajagopalan
2013-11-18 20:03 ` [PATCH 1 of 4 V5] remus: add libnl3 dependency to autoconf scripts Shriram Rajagopalan
2013-11-18 20:03 ` [PATCH 2 of 4 V5] tools/libxl: Remus network buffering - hotplug scripts and setup code Shriram Rajagopalan
2013-11-25 15:32   ` Ian Jackson
2013-12-19 19:37     ` Shriram Rajagopalan
2013-11-18 20:03 ` [PATCH 3 of 4 V5] tools/libxl: Control network buffering in remus callbacks Shriram Rajagopalan
2013-11-25 15:38   ` Ian Jackson
2013-11-18 20:03 ` [PATCH 4 of 4 V5] tools/xl: Remus - Network buffering cmdline switch Shriram Rajagopalan
2013-11-25 15:37   ` Ian Jackson
2013-12-12  5:45     ` Shriram Rajagopalan
2013-12-12 11:07       ` Ian Campbell
2013-12-12 15:13         ` Ian Jackson
2013-12-12 15:36           ` Ian Campbell
2013-12-12 15:12       ` Ian Jackson
2013-12-12 18:37         ` Shriram Rajagopalan
2013-12-12 18:43           ` Ian Jackson
2013-12-12 18:47           ` Brendan Cully
2013-12-12 18:52             ` Shriram Rajagopalan
2013-12-12 18:55               ` Brendan Cully
2013-11-19 16:23 ` Ian Campbell [this message]
2013-11-19 17:58   ` [PATCH 0 of 4 V5] Remus/Libxl: Network buffering support Shriram Rajagopalan
2013-11-24  6:51     ` Shriram Rajagopalan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1384878218.16252.27.camel@hastur.hellion.org.uk \
    --to=ian.campbell@citrix.com \
    --cc=George.Dunlap@citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=roger.pau@citrix.com \
    --cc=rshriram@cs.ubc.ca \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).