From: Ian Campbell <ian.campbell@citrix.com>
To: Julien Grall <julien.grall@linaro.org>
Cc: xen-devel@lists.xenproject.org, patches@linaro.org, tim@xen.org,
stefano.stabellini@eu.citrix.com
Subject: Re: [PATCH v2] xen/arm: ioremap_attr: return NULL is __vmap failed
Date: Tue, 19 Nov 2013 16:42:10 +0000 [thread overview]
Message-ID: <1384879330.16252.32.camel@hastur.hellion.org.uk> (raw)
In-Reply-To: <1384872343.30014.117.camel@kazak.uk.xensource.com>
On Tue, 2013-11-19 at 14:45 +0000, Ian Campbell wrote:
> On Mon, 2013-11-18 at 13:08 +0000, Julien Grall wrote:
> > Most of ioremap_* caller check if ioremap returns NULL. Actually, if the
> > physical address is non-aligned, Xen will return the pointer given by
> > __vmap plus the offset in the page. So if ioremap_* fails, the caller
> > will retrieve an non-NULL address and continue as if there was no error.
> >
> > Signed-off-by: Julien Grall <julien.grall@linaro.org>
> > Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
>
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
Applied this +
xen/arm: Panic if platform initialization failed
xen/arm: Panic if we are unable to initialize platform timer
from the first posting.
prev parent reply other threads:[~2013-11-19 16:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-18 13:08 [PATCH v2] xen/arm: ioremap_attr: return NULL is __vmap failed Julien Grall
2013-11-19 14:45 ` Ian Campbell
2013-11-19 16:42 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1384879330.16252.32.camel@hastur.hellion.org.uk \
--to=ian.campbell@citrix.com \
--cc=julien.grall@linaro.org \
--cc=patches@linaro.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).