From: Dario Faggioli <dario.faggioli@citrix.com>
To: Elena Ufimtseva <ufimtseva@gmail.com>
Cc: keir@xen.org, Ian.Campbell@citrix.com,
stefano.stabellini@eu.citrix.com, george.dunlap@eu.citrix.com,
msw@linux.com, lccycc123@gmail.com, ian.jackson@eu.citrix.com,
xen-devel@lists.xen.org, JBeulich@suse.com
Subject: Re: [PATCH v3 5/7] libxl: vNUMA configuration parser
Date: Tue, 19 Nov 2013 18:20:38 +0100 [thread overview]
Message-ID: <1384881638.19880.146.camel@Abyss> (raw)
In-Reply-To: <1384806262-12532-6-git-send-email-ufimtseva@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1011 bytes --]
Just one thing (for now)...
On lun, 2013-11-18 at 15:24 -0500, Elena Ufimtseva wrote:
> Signed-off-by: Elena Ufimtseva <ufimtseva@gmail.com>
> diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
> index 8690ec7..d7aa0b3 100644
> --- a/tools/libxl/xl_cmdimpl.c
> +++ b/tools/libxl/xl_cmdimpl.c
>
This is the only file you modify in the patch, so the patch itself is
about _xl_, rather than _libxl_, isn't it?
Please, make the subject consistent with that.
It's a big patch (and it should be even bigger, as you'll see from my
comments on patch 7/7) so, perhaps, consider splitting it up, e.g., by
having one patch for each new config option introduced (if feasible and
not too hard).
Thanks and Regards,
Dario
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2013-11-19 17:20 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-18 20:24 [PATCH v3 0/7] vNUMA introduction Elena Ufimtseva
2013-11-18 20:24 ` [PATCH v3 1/7] xen: vNUMA support for PV guests Elena Ufimtseva
2013-11-19 7:41 ` Dario Faggioli
2013-11-19 14:01 ` Jan Beulich
2013-11-19 14:35 ` Dario Faggioli
2013-11-19 14:48 ` Jan Beulich
2013-11-19 15:42 ` Dario Faggioli
2013-11-19 15:54 ` Jan Beulich
2013-11-19 16:36 ` Dario Faggioli
2013-11-19 16:43 ` Jan Beulich
2013-11-26 21:59 ` Elena Ufimtseva
2013-11-27 1:23 ` Dario Faggioli
2013-11-27 8:14 ` Jan Beulich
2013-12-02 17:06 ` Elena Ufimtseva
2013-12-02 17:09 ` Jan Beulich
2013-12-02 17:27 ` Elena Ufimtseva
2013-11-18 20:24 ` [PATCH v3 2/7] libxc: Plumb Xen with vNUMA topology for domain Elena Ufimtseva
2013-11-19 8:37 ` Dario Faggioli
2013-11-19 14:03 ` Konrad Rzeszutek Wilk
2013-11-19 22:06 ` Elena Ufimtseva
2013-11-18 20:24 ` [PATCH v3 3/7] libxc: vnodes allocation on NUMA nodes Elena Ufimtseva
2013-11-19 14:22 ` Dario Faggioli
2013-11-18 20:24 ` [PATCH v3 4/7] libxl: vNUMA supporting interface Elena Ufimtseva
2013-11-19 18:37 ` Dario Faggioli
2013-11-21 9:59 ` Li Yechen
2013-11-26 22:14 ` Elena Ufimtseva
2013-11-26 23:21 ` Dario Faggioli
2013-12-02 18:14 ` Elena Ufimtseva
2013-11-18 20:24 ` [PATCH v3 5/7] libxl: vNUMA configuration parser Elena Ufimtseva
2013-11-19 17:20 ` Dario Faggioli [this message]
2013-11-20 22:48 ` Matthew Daley
2013-11-21 3:20 ` Elena Ufimtseva
2013-11-18 20:24 ` [PATCH v3 6/7] xen: adds vNUMA info debug-key u Elena Ufimtseva
2013-11-22 18:15 ` Dario Faggioli
2013-11-18 20:24 ` [PATCH v3 7/7] xl: docs for xl config vnuma options Elena Ufimtseva
2013-11-19 17:23 ` Dario Faggioli
2013-11-19 17:26 ` George Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1384881638.19880.146.camel@Abyss \
--to=dario.faggioli@citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=JBeulich@suse.com \
--cc=george.dunlap@eu.citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=keir@xen.org \
--cc=lccycc123@gmail.com \
--cc=msw@linux.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=ufimtseva@gmail.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).