xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Wei Liu <wei.liu2@citrix.com>
To: xen-devel@lists.xen.org
Cc: Wei Liu <wei.liu2@citrix.com>
Subject: [PATCH RFC v2 4/4] hvmloader/ovmf: setup E820 map
Date: Tue, 19 Nov 2013 21:11:44 +0000	[thread overview]
Message-ID: <1384895504-13723-5-git-send-email-wei.liu2@citrix.com> (raw)
In-Reply-To: <1384895504-13723-1-git-send-email-wei.liu2@citrix.com>

E820 map will be used by OVMF to create memory map.

Modify build_e820_table to cope with the fact that OVMF doesn't actually
need to reserve bios_image_base - 0x100000.

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
 tools/firmware/hvmloader/e820.c |   20 +++++++++++---------
 tools/firmware/hvmloader/ovmf.c |   12 +++++++++++-
 2 files changed, 22 insertions(+), 10 deletions(-)

diff --git a/tools/firmware/hvmloader/e820.c b/tools/firmware/hvmloader/e820.c
index 2e05e93..bdb66f5 100644
--- a/tools/firmware/hvmloader/e820.c
+++ b/tools/firmware/hvmloader/e820.c
@@ -81,8 +81,6 @@ int build_e820_table(struct e820entry *e820,
     /* Lowmem must be at least 512K to keep Windows happy) */
     ASSERT ( lowmem_reserved_base > 512<<10 );
 
-    ASSERT ( bios_image_base < 0x100000 );
-
     /*
      * 0x0-lowmem_reserved_base: Ordinary RAM.
      */
@@ -109,13 +107,17 @@ int build_e820_table(struct e820entry *e820,
      * TODO: free pages which turn out to be unused.
      */
 
-    /*
-     * BIOS region.
-     */
-    e820[nr].addr = bios_image_base;
-    e820[nr].size = 0x100000-bios_image_base;
-    e820[nr].type = E820_RESERVED;
-    nr++;
+   /*
+    * BIOS region if we have one.
+    */
+    if ( bios_image_base != (unsigned int)-1 )
+    {
+        ASSERT ( bios_image_base < 0x100000 );
+        e820[nr].addr = bios_image_base;
+        e820[nr].size = 0x100000-bios_image_base;
+        e820[nr].type = E820_RESERVED;
+        nr++;
+    }
 
     /* Low RAM goes here. Reserve space for special pages. */
     BUG_ON((hvm_info->low_mem_pgend << PAGE_SHIFT) < (2u << 20));
diff --git a/tools/firmware/hvmloader/ovmf.c b/tools/firmware/hvmloader/ovmf.c
index 1564263..e17f4e1 100644
--- a/tools/firmware/hvmloader/ovmf.c
+++ b/tools/firmware/hvmloader/ovmf.c
@@ -138,6 +138,16 @@ static void ovmf_create_smbios_tables(void)
         SMBIOS_PHYSICAL_END);
 }
 
+static void ovmf_setup_e820(void)
+{
+    struct ovmf_info *info = (void *)OVMF_INFO_PHYSICAL_ADDRESS;
+    struct e820entry *e820 = scratch_alloc(sizeof(struct e820entry)*128, 0);
+    info->e820 = (uint32_t)e820;
+
+    info->e820_nr = build_e820_table(e820, 0, (unsigned int)-1);
+    dump_e820_table(e820, info->e820_nr);
+}
+
 struct bios_config ovmf_config =  {
     .name = "OVMF",
 
@@ -152,7 +162,7 @@ struct bios_config ovmf_config =  {
     .bios_info_setup = ovmf_setup_bios_info,
     .bios_info_finish = ovmf_finish_bios_info,
 
-    .e820_setup = NULL,
+    .e820_setup = ovmf_setup_e820,
 
     .acpi_build_tables = ovmf_acpi_build_tables,
     .create_mp_tables = NULL,
-- 
1.7.10.4

      parent reply	other threads:[~2013-11-19 21:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-19 21:11 [PATCH RFC v2 0/4] hvmloader: make OVMF work with Xen Wei Liu
2013-11-19 21:11 ` [PATCH RFC v2 1/4] hvmloader/ovmf: increase blob size to 2MB Wei Liu
2013-11-19 21:11 ` [PATCH RFC v2 2/4] hvmloader/ovmf: show OVMF_BEGIN as bios address Wei Liu
2013-11-19 21:11 ` [PATCH RFC v2 3/4] hvmloader/ovmf: setup ovmf_info Wei Liu
2013-11-19 21:35   ` Konrad Rzeszutek Wilk
2013-11-19 21:11 ` Wei Liu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1384895504-13723-5-git-send-email-wei.liu2@citrix.com \
    --to=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).