From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v3 11/14] libxl: get and set soft affinity Date: Wed, 20 Nov 2013 12:40:34 +0100 Message-ID: <1384947634.15360.52.camel@Solace> References: <20131118175544.31002.79574.stgit@Solace> <20131118181813.31002.61195.stgit@Solace> <1384881864.16252.48.camel@hastur.hellion.org.uk> <1384883478.19880.170.camel@Abyss> <1384946825.28441.56.camel@kazak.uk.xensource.com> <528C9D0D.8020302@eu.citrix.com> <1384947125.28441.60.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1536537865023379965==" Return-path: In-Reply-To: <1384947125.28441.60.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Marcus Granado , Keir Fraser , Matt Wilson , Li Yechen , George Dunlap , Andrew Cooper , Juergen Gross , Ian Jackson , xen-devel@lists.xen.org, Jan Beulich , Justin Weaver , Elena Ufimtseva List-Id: xen-devel@lists.xenproject.org --===============1536537865023379965== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-DHqo2zZscIgfnrsWj1mq" --=-DHqo2zZscIgfnrsWj1mq Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On mer, 2013-11-20 at 11:32 +0000, Ian Campbell wrote: > On Wed, 2013-11-20 at 11:29 +0000, George Dunlap wrote: > > On 20/11/13 11:27, Ian Campbell wrote: > > >> I did actually check and, of all the enum-s in the IDL, none are use= d as > > >> flags, they're rather used as "single values". OTOH, the only actual > > >> flags I found (I think it was LIBXL_SUSPEND_DEBUG, LIBXL_SUSPEND_LIV= E) > > >> were defined like I did myself above... That's why I went for it. > > > I have a feeling they predate the IDL, or at least the Enumeration > > > support. It's true that we don't have any other bit fields in enums > > > though. I can't see the harm, it's probably not worth introducing a n= ew > > > IDL type for them. > >=20 > > Since these are bits, not numbers, I don't think an enum is the right= =20 > > construct. Or, the enum values should be the *bit numbers*, and the= =20 > > flags should be (1<<[bit_humber]). >=20 > That would need a new IDL type to express. In which case lets just leave > the raw #defines, unless anyone else has a strong opinion. >=20 That would probably the best option, at least for now. Of course, I can add "introduce a new IDL type for bitfields" to my TODO list, and send a followup patch for 4.5. Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-DHqo2zZscIgfnrsWj1mq Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) iEYEABECAAYFAlKMn7IACgkQk4XaBE3IOsQirgCdGEk53fiAaWrEQ0uJLACM4QUV qWsAn3O8pCsp7uJdZq5zZwyABBS0B/wV =1SMn -----END PGP SIGNATURE----- --=-DHqo2zZscIgfnrsWj1mq-- --===============1536537865023379965== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============1536537865023379965==--