xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Mukesh Rathor <mukesh.rathor@oracle.com>
To: Xen-devel@lists.xensource.com
Cc: keir.xen@gmail.com, tim@xen.org, JBeulich@suse.com
Subject: [V2 PATCH 1/8] PVH dom0: iommu related changes
Date: Fri, 22 Nov 2013 16:03:31 -0800	[thread overview]
Message-ID: <1385165018-25933-2-git-send-email-mukesh.rathor@oracle.com> (raw)
In-Reply-To: <1385165018-25933-1-git-send-email-mukesh.rathor@oracle.com>

- For now, iommu is required for PVH dom0. Check for that.
- For pvh, we need to do mfn_to_gmfn before calling mapping function
  intel_iommu_map_page/amd_iommu_map_page which expects a gfn.

Signed-off-by: Mukesh Rathor <mukesh.rathor@oracle.com>
---
 xen/drivers/passthrough/iommu.c |   17 +++++++++++++++--
 1 files changed, 15 insertions(+), 2 deletions(-)

diff --git a/xen/drivers/passthrough/iommu.c b/xen/drivers/passthrough/iommu.c
index 93ad122..dbbd034 100644
--- a/xen/drivers/passthrough/iommu.c
+++ b/xen/drivers/passthrough/iommu.c
@@ -125,15 +125,27 @@ int iommu_domain_init(struct domain *d)
     return hd->platform_ops->init(d);
 }
 
+static __init void check_dom0_pvh_reqs(struct domain *d)
+{
+    if ( !iommu_enabled )
+        panic("Presently, iommu must be enabled for pvh dom0\n");
+
+    if ( iommu_passthrough )
+        panic("For pvh dom0, dom0-passthrough must not be enabled\n");
+}
+
 void __init iommu_dom0_init(struct domain *d)
 {
     struct hvm_iommu *hd = domain_hvm_iommu(d);
 
+    if ( is_pvh_domain(d) )
+        check_dom0_pvh_reqs(d);
+
     if ( !iommu_enabled )
         return;
 
     register_keyhandler('o', &iommu_p2m_table);
-    d->need_iommu = !!iommu_dom0_strict;
+    d->need_iommu = is_pvh_domain(d) || !!iommu_dom0_strict;
     if ( need_iommu(d) )
     {
         struct page_info *page;
@@ -141,12 +153,13 @@ void __init iommu_dom0_init(struct domain *d)
         page_list_for_each ( page, &d->page_list )
         {
             unsigned long mfn = page_to_mfn(page);
+            unsigned long gfn = mfn_to_gmfn(d, mfn);
             unsigned int mapping = IOMMUF_readable;
             if ( ((page->u.inuse.type_info & PGT_count_mask) == 0) ||
                  ((page->u.inuse.type_info & PGT_type_mask)
                   == PGT_writable_page) )
                 mapping |= IOMMUF_writable;
-            hd->platform_ops->map_page(d, mfn, mfn, mapping);
+            hd->platform_ops->map_page(d, gfn, mfn, mapping);
             if ( !(i++ & 0xfffff) )
                 process_pending_softirqs();
         }
-- 
1.7.2.3

  reply	other threads:[~2013-11-23  0:03 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-23  0:03 [V2 PATCH 0/8]: PVH dom0 Mukesh Rathor
2013-11-23  0:03 ` Mukesh Rathor [this message]
2013-11-25  1:19   ` [V2 PATCH 1/8] PVH dom0: iommu related changes Konrad Rzeszutek Wilk
2013-11-25  8:47     ` Jan Beulich
2013-11-25  8:35   ` Jan Beulich
2013-11-26 14:57   ` George Dunlap
2013-11-23  0:03 ` [V2 PATCH 2/8] PVH dom0: create update_memory_mapping() function Mukesh Rathor
2013-11-25  8:43   ` Jan Beulich
2013-11-25 23:20     ` Mukesh Rathor
2013-11-23  0:03 ` [V2 PATCH 3/8] PVH dom0: move some pv specific code to static functions Mukesh Rathor
2013-11-23  0:03 ` [V2 PATCH 4/8] dom0: construct_dom0 changes Mukesh Rathor
2013-11-23  0:03 ` [V2 PATCH 5/8] PVH dom0: implement XENMEM_add_to_physmap_range for x86 Mukesh Rathor
2013-11-23  0:03 ` [V2 PATCH 6/8] PVH dom0: Introduce p2m_map_foreign Mukesh Rathor
2013-11-26 16:00   ` George Dunlap
2013-11-26 16:11     ` Ian Campbell
2013-11-26 17:35       ` George Dunlap
2013-11-23  0:03 ` [V2 PATCH 7/8] pvh dom0: Add and remove foreign pages Mukesh Rathor
2013-11-25  9:03   ` Jan Beulich
2013-11-25 19:00     ` Daniel De Graaf
2013-11-26  0:32       ` Mukesh Rathor
2013-11-26 15:03         ` Daniel De Graaf
2013-11-27  1:19           ` Mukesh Rathor
2013-11-23  0:03 ` [V2 PATCH 8/8] pvh dom0: add opt_dom0pvh to setup.c Mukesh Rathor
2013-11-25  9:04   ` Jan Beulich
2013-11-26  1:18     ` Mukesh Rathor
2013-11-25  9:06 ` [V2 PATCH 0/8]: PVH dom0 Jan Beulich
2013-11-25 10:49   ` George Dunlap
2013-11-25 10:57     ` Roger Pau Monné
2013-11-25 11:02       ` Jan Beulich
2013-11-26 17:20         ` George Dunlap
2013-11-26 18:06           ` Jan Beulich
2013-11-27  1:32             ` Mukesh Rathor
2013-11-25 11:05     ` Jan Beulich
2013-11-25 11:02 ` Roger Pau Monné

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1385165018-25933-2-git-send-email-mukesh.rathor@oracle.com \
    --to=mukesh.rathor@oracle.com \
    --cc=JBeulich@suse.com \
    --cc=Xen-devel@lists.xensource.com \
    --cc=keir.xen@gmail.com \
    --cc=tim@xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).