xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xen.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
	Keir Fraser <keir@xen.org>, Jan Beulich <JBeulich@suse.com>
Subject: [PATCH 4/4] tools/libxl: Fix memory leak in sched_domain_output()
Date: Mon, 25 Nov 2013 11:12:53 +0000	[thread overview]
Message-ID: <1385377973-21401-5-git-send-email-andrew.cooper3@citrix.com> (raw)
In-Reply-To: <1385377973-21401-1-git-send-email-andrew.cooper3@citrix.com>

Coverity ID: 1055904

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Keir Fraser <keir@xen.org>
CC: Jan Beulich <JBeulich@suse.com>
---
 tools/libxl/xl_cmdimpl.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
index 341863e..bdb4be3 100644
--- a/tools/libxl/xl_cmdimpl.c
+++ b/tools/libxl/xl_cmdimpl.c
@@ -5094,6 +5094,7 @@ static int sched_domain_output(libxl_scheduler sched, int (*output)(int),
     poolinfo = libxl_list_cpupool(ctx, &n_pools);
     if (!poolinfo) {
         fprintf(stderr, "error getting cpupool info\n");
+        libxl_dominfo_list_free(info, nb_domain);
         return -ERROR_NOMEM;
     }
 
@@ -5115,6 +5116,7 @@ static int sched_domain_output(libxl_scheduler sched, int (*output)(int),
     }
 
     libxl_cpupoolinfo_list_free(poolinfo, n_pools);
+    libxl_dominfo_list_free(info, nb_domain);
     return 0;
 }
 
-- 
1.7.10.4

  parent reply	other threads:[~2013-11-25 11:12 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-25 11:12 [PATCH 0/4] Coverity fixes for tools/libxl Andrew Cooper
2013-11-25 11:12 ` [PATCH 1/4] tools/libxl: Avoid deliberate NULL pointer dereference Andrew Cooper
2013-11-25 12:32   ` Ian Jackson
2013-11-25 11:12 ` [PATCH 2/4] tools/libxl: Fix integer overflows in sched_sedf_domain_set() Andrew Cooper
2013-11-25 12:35   ` Ian Jackson
2013-11-25 11:12 ` [PATCH 3/4] tools/libxl: Fix libxl__device_nic_from_xs_be() Andrew Cooper
2013-11-25 11:38   ` Roger Pau Monné
2013-11-25 15:19     ` [Patch v2 " Andrew Cooper
2013-11-25 18:52       ` Roger Pau Monné
2013-11-25 20:49         ` [Patch v3 " Andrew Cooper
2013-11-26  8:11           ` Roger Pau Monné
2013-11-26 11:32           ` Ian Jackson
2013-11-26 11:42             ` Andrew Cooper
2013-11-26 12:09               ` Ian Jackson
2013-11-26 13:58                 ` Andrew Cooper
2013-11-26 15:08                   ` Ian Jackson
2013-11-26 15:15                     ` Andrew Cooper
2013-11-26 15:39                       ` Ian Jackson
2013-12-09 13:35                         ` Andrew Cooper
2013-12-18 11:11                         ` Ian Campbell
2013-12-18 11:10                       ` Ian Campbell
2013-11-25 12:38   ` [PATCH " Ian Jackson
2013-11-25 11:12 ` Andrew Cooper [this message]
2013-11-25 13:46   ` [PATCH 4/4] tools/libxl: Fix memory leak in sched_domain_output() Ian Jackson
2013-11-25 13:48     ` Andrew Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1385377973-21401-5-git-send-email-andrew.cooper3@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=keir@xen.org \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).