From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Jackson Subject: [PATCH] libxl: introduce an option for disabling the non-O_DIRECT workaround Date: Tue, 26 Nov 2013 11:42:31 +0000 Message-ID: <1385466151-21481-2-git-send-email-ian.jackson@eu.citrix.com> References: <1385466151-21481-1-git-send-email-ian.jackson@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1VlH2p-0007cT-Dk for xen-devel@lists.xenproject.org; Tue, 26 Nov 2013 11:43:08 +0000 In-Reply-To: <1385466151-21481-1-git-send-email-ian.jackson@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xenproject.org Cc: George Dunlap , Ian Jackson , Ian Campbell , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org From: Stefano Stabellini Document and implement a new option that permits disk backends which would otherwise have to avoid O_DIRECT (because of the network memory lifetime bug) to use it anyway. This is: direct-io-safe in the xl domain disk config specification direct_io_safe in the libxl disk API direct-io-safe in the backend xenstore interface Add a reference to xen/include/public/io/blkif.h in docs/misc/vbd-interface.txt. Signed-off-by: Stefano Stabellini Signed-off-by: Ian Jackson Acked-by: Ian Campbell --- docs/misc/vbd-interface.txt | 6 + docs/misc/xl-disk-configuration.txt | 38 ++ tools/libxl/libxl.c | 4 + tools/libxl/libxl.h | 7 + tools/libxl/libxl_types.idl | 1 + tools/libxl/libxlu_disk_l.c | 681 ++++++++++++++++++----------------- tools/libxl/libxlu_disk_l.h | 2 +- tools/libxl/libxlu_disk_l.l | 1 + xen/include/public/io/blkif.h | 22 ++ 9 files changed, 428 insertions(+), 334 deletions(-) diff --git a/docs/misc/vbd-interface.txt b/docs/misc/vbd-interface.txt index 3952e73..f873db0 100644 --- a/docs/misc/vbd-interface.txt +++ b/docs/misc/vbd-interface.txt @@ -125,3 +125,9 @@ because they directly map the bottom 8 bits of the xenstore integer directly to the Linux guest's device number and throw away the rest; they can crash due to minor number clashes. With these guests, the workaround is not to supply problematic combinations of devices. + + +Other frontend and backend options +---------------------------------- + +See xen/include/public/io/blkif.h for the full list of options. diff --git a/docs/misc/xl-disk-configuration.txt b/docs/misc/xl-disk-configuration.txt index 5bd456d..9c2650b 100644 --- a/docs/misc/xl-disk-configuration.txt +++ b/docs/misc/xl-disk-configuration.txt @@ -178,6 +178,44 @@ information to be interpreted by the executable program