xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Mukesh Rathor <mukesh.rathor@oracle.com>
To: Xen-devel@lists.xensource.com
Cc: george.dunlap@eu.citrix.com, keir.xen@gmail.com, tim@xen.org,
	JBeulich@suse.com
Subject: [V3 PATCH 2/9] PVH dom0: create add_mem_mapping_for_xlate() function
Date: Tue, 26 Nov 2013 18:27:03 -0800	[thread overview]
Message-ID: <1385519230-21132-3-git-send-email-mukesh.rathor@oracle.com> (raw)
In-Reply-To: <1385519230-21132-1-git-send-email-mukesh.rathor@oracle.com>

In this preparatory patch, add portion of XEN_DOMCTL_memory_mapping
code is put into a function so it can be called later for PVH from
construct_dom0. There is no change in it's functionality.
The function is made non-static in the construct_dom0 patch.

Signed-off-by: Mukesh Rathor <mukesh.rathor@oracle.com>
---
 xen/arch/x86/domctl.c |   48 ++++++++++++++++++++++++++++++------------------
 1 files changed, 30 insertions(+), 18 deletions(-)

diff --git a/xen/arch/x86/domctl.c b/xen/arch/x86/domctl.c
index 8644218..e3f544a 100644
--- a/xen/arch/x86/domctl.c
+++ b/xen/arch/x86/domctl.c
@@ -46,6 +46,35 @@ static int gdbsx_guest_mem_io(
     return (iop->remain ? -EFAULT : 0);
 }
 
+static int add_mem_mapping_for_xlate(struct domain *d, unsigned long gfn,
+                              unsigned long mfn, unsigned long nr_mfns)
+{
+    unsigned long i;
+    int ret = 0;
+
+    for ( i = 0; i < nr_mfns; i++ )
+        if ( !set_mmio_p2m_entry(d, gfn + i, _mfn(mfn + i)) )
+            ret = -EIO;
+    if ( ret )
+    {
+        if ( is_hardware_domain(d) )
+            panic("Failed setting p2m. ret:%d gfn:%lx mfn:%lx i:%ld\n",
+                  ret, gfn, mfn, i);
+
+        printk(XENLOG_G_WARNING
+               "memory_map:fail: dom%d gfn=%lx mfn=%lx\n",
+               d->domain_id, gfn + i, mfn + i);
+        while ( i-- )
+            clear_mmio_p2m_entry(d, gfn + i);
+        if ( iomem_deny_access(d, mfn, mfn + nr_mfns - 1) &&
+             is_hardware_domain(current->domain) )
+            printk(XENLOG_ERR
+                   "memory_map: failed to deny dom%d access to [%lx,%lx]\n",
+                   d->domain_id, mfn, mfn + nr_mfns - 1);
+    }
+    return ret;
+}
+
 long arch_do_domctl(
     struct xen_domctl *domctl, struct domain *d,
     XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl)
@@ -649,24 +678,7 @@ long arch_do_domctl(
 
             ret = iomem_permit_access(d, mfn, mfn + nr_mfns - 1);
             if ( !ret && paging_mode_translate(d) )
-            {
-                for ( i = 0; !ret && i < nr_mfns; i++ )
-                    if ( !set_mmio_p2m_entry(d, gfn + i, _mfn(mfn + i)) )
-                        ret = -EIO;
-                if ( ret )
-                {
-                    printk(XENLOG_G_WARNING
-                           "memory_map:fail: dom%d gfn=%lx mfn=%lx\n",
-                           d->domain_id, gfn + i, mfn + i);
-                    while ( i-- )
-                        clear_mmio_p2m_entry(d, gfn + i);
-                    if ( iomem_deny_access(d, mfn, mfn + nr_mfns - 1) &&
-                         is_hardware_domain(current->domain) )
-                        printk(XENLOG_ERR
-                               "memory_map: failed to deny dom%d access to [%lx,%lx]\n",
-                               d->domain_id, mfn, mfn + nr_mfns - 1);
-                }
-            }
+                ret = add_mem_mapping_for_xlate(d, gfn, mfn, nr_mfns);
         }
         else
         {
-- 
1.7.2.3

  parent reply	other threads:[~2013-11-27  2:27 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-27  2:27 [V3 PATCH 0/9]: PVH dom0 Mukesh Rathor
2013-11-27  2:27 ` [V3 PATCH 1/9] PVH dom0: iommu related changes Mukesh Rathor
2013-11-27  2:27 ` Mukesh Rathor [this message]
2013-12-02 12:16   ` [V3 PATCH 2/9] PVH dom0: create add_mem_mapping_for_xlate() function Jan Beulich
2013-11-27  2:27 ` [V3 PATCH 3/9] PVH dom0: move some pv specific code to static functions Mukesh Rathor
2013-12-02 12:30   ` Jan Beulich
2013-11-27  2:27 ` [V3 PATCH 4/9] dom0: construct_dom0 changes Mukesh Rathor
2013-12-02 12:36   ` Jan Beulich
2013-11-27  2:27 ` [V3 PATCH 5/9] PVH dom0: implement XENMEM_add_to_physmap_range for x86 Mukesh Rathor
2013-12-02 12:47   ` Jan Beulich
2013-12-03  0:05     ` Mukesh Rathor
2013-12-03  7:48       ` Jan Beulich
2013-12-03 19:49         ` Mukesh Rathor
2013-12-04  8:03           ` Jan Beulich
2013-11-27  2:27 ` [V3 PATCH 6/9] PVH dom0: Introduce p2m_map_foreign Mukesh Rathor
2013-11-27  2:27 ` [V3 PATCH 7/9] pvh: change xsm_add_to_physmap Mukesh Rathor
2013-11-27 16:46   ` Daniel De Graaf
2013-11-27 20:29     ` Mukesh Rathor
2013-11-29  9:21       ` Jan Beulich
2013-12-02 12:55   ` Jan Beulich
2013-11-27  2:27 ` [V3 PATCH 8/9] pvh dom0: Add and remove foreign pages Mukesh Rathor
2013-12-02 12:57   ` Jan Beulich
2013-11-27  2:27 ` [V3 PATCH 9/9] pvh dom0: add opt_dom0pvh to setup.c Mukesh Rathor
2013-11-27 15:00   ` George Dunlap
2013-11-27 20:12     ` Mukesh Rathor
2013-11-28 11:54       ` George Dunlap
2013-11-29  9:29         ` Jan Beulich
2013-12-02 13:00   ` Jan Beulich
2013-12-02 15:09   ` Roger Pau Monné
2013-12-02 19:30     ` Mukesh Rathor
2013-12-02 19:38       ` Roger Pau Monné
2013-12-02 20:38         ` Mukesh Rathor
2013-12-02 20:46           ` Mukesh Rathor
2013-12-03  2:33             ` Mukesh Rathor
2013-12-03 10:30               ` Roger Pau Monné
2013-12-03 19:51                 ` Mukesh Rathor
2013-12-03 10:54         ` Jan Beulich
2013-11-28 12:07 ` [V3 PATCH 0/9]: PVH dom0 George Dunlap
2013-11-29  9:17   ` Jan Beulich
2013-12-02 11:39     ` George Dunlap
2013-12-01 23:53   ` Mukesh Rathor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1385519230-21132-3-git-send-email-mukesh.rathor@oracle.com \
    --to=mukesh.rathor@oracle.com \
    --cc=JBeulich@suse.com \
    --cc=Xen-devel@lists.xensource.com \
    --cc=george.dunlap@eu.citrix.com \
    --cc=keir.xen@gmail.com \
    --cc=tim@xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).