From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v4 10/15] xen: sched: DOMCTL_*vcpuaffinity works with hard and soft affinity Date: Wed, 27 Nov 2013 15:31:17 +0100 Message-ID: <1385562677.15201.207.camel@Solace> References: <20131122183332.11200.20231.stgit@Solace> <20131122185758.11200.44816.stgit@Solace> <5295FDA702000078001078EC@nat28.tlf.novell.com> <5295FF04.9010003@eu.citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8271874205892419482==" Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Vlg9F-00078q-Gb for xen-devel@lists.xenproject.org; Wed, 27 Nov 2013 14:31:25 +0000 In-Reply-To: <5295FF04.9010003@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: George Dunlap Cc: Marcus Granado , Justin Weaver , Jan Beulich , Li Yechen , Andrew Cooper , Juergen Gross , Ian Jackson , Matt Wilson , xen-devel , Keir Fraser , Elena Ufimtseva , Ian Campbell List-Id: xen-devel@lists.xenproject.org --===============8271874205892419482== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-heyQdHfguw9wW56WUp35" --=-heyQdHfguw9wW56WUp35 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On mer, 2013-11-27 at 14:17 +0000, George Dunlap wrote: > On 11/27/2013 01:11 PM, Jan Beulich wrote: > >>>> On 22.11.13 at 19:57, Dario Faggioli wro= te: > >> + /* > >> + * Report back to the caller what the "effective affinity= ", that > >> + * is the intersection of cpupool's pcpus, the (new?) har= d > >> + * affinity and the (new?) soft-affinity. > >> + */ > >> + if ( !guest_handle_is_null(op->u.vcpuaffinity.eff_cpumap.= bitmap) ) > >> { > >> - ret =3D vcpu_set_affinity(v, new_affinity); > >> - free_cpumask_var(new_affinity); > >> + online =3D cpupool_online_cpumask(v->domain->cpupool)= ; > >> + cpumask_and(new_affinity, online, v->cpu_hard_affinit= y); > >> + if ( op->u.vcpuaffinity.flags & XEN_VCPUAFFINITY_SOFT= ) > >> + cpumask_and(new_affinity, new_affinity, > >> + v->cpu_soft_affinity); > >> + > >> + ret =3D cpumask_to_xenctl_bitmap( > >> + &op->u.vcpuaffinity.eff_cpumap, new_affinity); > > So with both flags set, how is the caller supposed to know what > > hard affinity is now in effect? I said on the previous version already > > that with you _having_ two CPU masks, you should return both. >=20 > If I recall the timing correctly, I think this series was sent out=20 > before you guys had come to that conclusion on the other thread. >=20 Indeed. Anyway, new version implementing exactly what we agreed upon there coming shortly (for real, I just got sidetracked by a couple of other stuff, but it's almost ready). Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-heyQdHfguw9wW56WUp35 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) iEYEABECAAYFAlKWAjUACgkQk4XaBE3IOsSvpQCfT11azJuS7zrC2NsgQcF0CS5S n/EAn15GVLSw9B6mXkON1CtQ2ORETvxd =PdGb -----END PGP SIGNATURE----- --=-heyQdHfguw9wW56WUp35-- --===============8271874205892419482== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============8271874205892419482==--