From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Daley Subject: [PATCH] memshr: fix off-by-one in filename size check Date: Thu, 28 Nov 2013 23:17:11 +1300 Message-ID: <1385633831-12816-1-git-send-email-mattd@bugfuzz.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xenproject.org Cc: xen-devel@lists.xen.org, Matthew Daley , Ian Jackson , Ian Campbell , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org Signed-off-by: Matthew Daley --- tools/memshr/shm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/memshr/shm.c b/tools/memshr/shm.c index c925cf2..30975dc 100644 --- a/tools/memshr/shm.c +++ b/tools/memshr/shm.c @@ -217,9 +217,9 @@ uint16_t shm_vbd_image_get(const char* file, vbd_image_info_t *vbd_imgs) DPRINTF("No space in vbds table.\n"); return 0; } - if(strlen(file) > MAX_NAME_LEN) + if(strlen(file) > MAX_NAME_LEN - 1) { - DPRINTF("Filename: %s too long (>%d).\n", file, MAX_NAME_LEN); + DPRINTF("Filename: %s too long (>%d).\n", file, MAX_NAME_LEN - 1); return 0; } /* Init the entry */ -- 1.7.10.4