xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Dario Faggioli <dario.faggioli@citrix.com>
To: George Dunlap <george.dunlap@eu.citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
	Jan Beulich <JBeulich@suse.com>,
	Xen-devel List <xen-devel@lists.xen.org>
Subject: Re: Xen-4.3 and -unstable regression from changeset "numa-sched: leave node-affinity alone if not in 'auto' mode"
Date: Thu, 28 Nov 2013 16:14:16 +0100	[thread overview]
Message-ID: <1385651656.20797.146.camel@Abyss> (raw)
In-Reply-To: <52975CBD.8010408@eu.citrix.com>


[-- Attachment #1.1: Type: text/plain, Size: 1242 bytes --]

On gio, 2013-11-28 at 15:09 +0000, George Dunlap wrote:
> On 11/28/2013 12:31 PM, Andrew Cooper wrote:
> Do you have a xen-syms you can use to find out what line the crash 
> happened at?
> 
Yep, that would be helpful...

> Dom0 should have auto_node_affinity set at this point; so before this 
> patch you'd have:
>   nodemask = NODEMASK_MASK_NONE;
>   [set nodes in nodemask from cpumask]
>   d->node_affinity=nodemask
> 
> After, you have:
>   nodes_clear(d->node_affinity)
>   [set nodes in d->node_affinity from cpumask]
> 
> Everything looks like it should be the same.
> 
Exactly! I really don't see what could be happening.

Anyway, I've now access to the machine and can try doing some
debugging...

> Can you try just reverting what's in the positive side of the if()? 
> I.e., adding back in nodemask=NODE_MASK_NONE at the top, and the 
> nodemask copying, and see what happens?
> 
...Including this, and let you know.

Regards,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2013-11-28 15:14 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-28 12:31 Xen-4.3 and -unstable regression from changeset "numa-sched: leave node-affinity alone if not in 'auto' mode" Andrew Cooper
2013-11-28 13:05 ` Dario Faggioli
2013-11-28 15:09 ` George Dunlap
2013-11-28 15:14   ` Dario Faggioli [this message]
2013-11-28 15:16     ` Andrew Cooper
2013-11-28 21:17 ` Andrew Cooper
2013-11-28 23:30   ` George Dunlap
2013-11-29 10:51   ` Ian Campbell
2013-11-29 11:04     ` Andrew Cooper
2013-12-02 14:01       ` Andrew Cooper
2013-12-02 14:36         ` Jan Beulich
2013-12-03 19:53           ` Andrew Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1385651656.20797.146.camel@Abyss \
    --to=dario.faggioli@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=george.dunlap@eu.citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).