From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: Xen-4.3 and -unstable regression from changeset
 "numa-sched: leave node-affinity alone if not in 'auto' mode"
Date: Thu, 28 Nov 2013 16:14:16 +0100
Message-ID: <1385651656.20797.146.camel@Abyss>
References: <529737AD.7070708@citrix.com> <52975CBD.8010408@eu.citrix.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3408972535335365864=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <52975CBD.8010408@eu.citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: George Dunlap <george.dunlap@eu.citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich <JBeulich@suse.com>, Xen-devel List <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

--===============3408972535335365864==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-dMMXga+HEEvbSNf/kCTz"

--=-dMMXga+HEEvbSNf/kCTz
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On gio, 2013-11-28 at 15:09 +0000, George Dunlap wrote:
> On 11/28/2013 12:31 PM, Andrew Cooper wrote:
> Do you have a xen-syms you can use to find out what line the crash=20
> happened at?
>=20
Yep, that would be helpful...

> Dom0 should have auto_node_affinity set at this point; so before this=20
> patch you'd have:
>   nodemask =3D NODEMASK_MASK_NONE;
>   [set nodes in nodemask from cpumask]
>   d->node_affinity=3Dnodemask
>=20
> After, you have:
>   nodes_clear(d->node_affinity)
>   [set nodes in d->node_affinity from cpumask]
>=20
> Everything looks like it should be the same.
>=20
Exactly! I really don't see what could be happening.

Anyway, I've now access to the machine and can try doing some
debugging...

> Can you try just reverting what's in the positive side of the if()?=20
> I.e., adding back in nodemask=3DNODE_MASK_NONE at the top, and the=20
> nodemask copying, and see what happens?
>=20
...Including this, and let you know.

Regards,
Dario

--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


--=-dMMXga+HEEvbSNf/kCTz
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.15 (GNU/Linux)

iEYEABECAAYFAlKXXcgACgkQk4XaBE3IOsSGYgCfcNkD5XQ2QrvMxiMhAcezE7Y4
9lMAoIZmP9oI1t1jOY7zAQ2whR4rYaBT
=aBwx
-----END PGP SIGNATURE-----

--=-dMMXga+HEEvbSNf/kCTz--


--===============3408972535335365864==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============3408972535335365864==--