xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Tim Deegan <tim@xen.org>
To: xen-devel@lists.xen.org
Subject: [PATCH 3/4] x86/mem_sharing: drop unused variable.
Date: Thu, 28 Nov 2013 16:37:44 +0000	[thread overview]
Message-ID: <1385656665-12551-4-git-send-email-tim@xen.org> (raw)
In-Reply-To: <1385656665-12551-1-git-send-email-tim@xen.org>

Coverity CID 1087198

Signed-off-by: Tim Deegan <tim@xen.org>
---
 xen/arch/x86/mm/mem_sharing.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/xen/arch/x86/mm/mem_sharing.c b/xen/arch/x86/mm/mem_sharing.c
index 1e89f6c..8355f94 100644
--- a/xen/arch/x86/mm/mem_sharing.c
+++ b/xen/arch/x86/mm/mem_sharing.c
@@ -833,7 +833,6 @@ int mem_sharing_nominate_page(struct domain *d,
     mfn_t mfn;
     struct page_info *page = NULL; /* gcc... */
     int ret;
-    struct gfn_info *gfn_info;
 
     *phandle = 0UL;
 
@@ -892,7 +891,7 @@ int mem_sharing_nominate_page(struct domain *d,
     page->sharing->handle = get_next_handle();  
 
     /* Create the local gfn info */
-    if ( (gfn_info = mem_sharing_gfn_alloc(page, d, gfn)) == NULL )
+    if ( mem_sharing_gfn_alloc(page, d, gfn) == NULL )
     {
         xfree(page->sharing);
         page->sharing = NULL;
-- 
1.8.4.rc3

  parent reply	other threads:[~2013-11-28 16:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-28 16:37 [PATCH 0/4] xen: more Coverity-inspired tidying Tim Deegan
2013-11-28 16:37 ` [PATCH 1/4] common/vsprintf: Explicitly treat negative lengths as 'unlimited' Tim Deegan
2013-11-28 16:48   ` Andrew Cooper
2013-11-29 10:45     ` Ian Campbell
2013-11-28 16:37 ` [PATCH 2/4] x86/shadow: Drop shadow_mode_trap_reads() Tim Deegan
2013-11-28 16:37 ` Tim Deegan [this message]
2013-11-28 16:50   ` [PATCH 3/4] x86/mem_sharing: drop unused variable Andrew Cooper
2013-11-28 16:37 ` [PATCH 4/4] bitmaps/bitops: Clarify tests for small constant size Tim Deegan
2013-11-29 10:07   ` Jan Beulich
2013-11-29 10:37     ` Tim Deegan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1385656665-12551-4-git-send-email-tim@xen.org \
    --to=tim@xen.org \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).